8000 [PhpUnitBridge] Revert 7f62133939b1172e1c9924d211e1d315230b3be8 by nicolas-grekas · Pull Request #18198 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PhpUnitBridge] Revert 7f62133939b1172e1c9924d211e1d315230b3be8 #18198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2016
Merged

[PhpUnitBridge] Revert 7f62133939b1172e1c9924d211e1d315230b3be8 #18198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[PhpUnitBridge] Revert 7f62133
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Mar 16, 2016
commit b2293515a491db91e8ee85178558461374161a77
4 changes: 3 additions & 1 deletion src/Symfony/Bridge/PhpUnit/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
}
],
"require": {
"php": ">=5.3.9"
"php": ">=5.3.3 EVEN ON LATEST SYMFONY VERSIONS TO ALLOW USING",
"php": "THIS BRIDGE WHEN TESTING LOWEST SYMFONY VERSIONS.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer itself uses the underscore to add something like a comment: https://github.com/composer/composer/blob/master/composer.json#L41 Should we do that to to avoid confusion when reading this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this "trick" of duplicating keys to add comments to jsons is a good one a deserves wide spread knowledge, this patch contributes to it :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh your proposal would not work here, as we are inside require, which is a map, not an object where composer will only read keys it knows.
thus, even using _ at the top level would be a bad idea: the composer.json would not validate against the schema anymore (composer uses it in the lock file, which is not validated against a schema).

"php": ">=5.3.3"
},
"suggest": {
"symfony/debug": "For tracking deprecated interfaces usages at runtime with DebugClassLoader"
Expand Down
0