[PhpUnitBridge] Revert 7f62133939b1172e1c9924d211e1d315230b3be8 #18198
Conversation
| Q | A |
|---|---|
| Branch | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | 7f62133 |
| License | MIT |
| Doc PR | - |
This PR was merged into the 2.7 branch. Discussion ---------- [PhpUnitBridge] Revert 7f62133 | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | 7f62133 | License | MIT | Doc PR | - Commits ------- b229351 [PhpUnitBridge] Revert 7f62133
| @@ -16,7 +16,9 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.9" | |||
| "php": ">=5.3.3 EVEN ON LATEST SYMFONY VERSIONS TO ALLOW USING", | |||
| "php": "THIS BRIDGE WHEN TESTING LOWEST SYMFONY VERSIONS.", | |||
There was a problem hiding this comment.
Composer itself uses the underscore to add something like a comment: https://github.com/composer/composer/blob/master/composer.json#L41 Should we do that to to avoid confusion when reading this?
There was a problem hiding this comment.
I think this "trick" of duplicating keys to add comments to jsons is a good one a deserves wide spread knowledge, this patch contributes to it :)
There was a problem hiding this comment.
@xabbuh your proposal would not work here, as we are inside require, which is a map, not an object where composer will only read keys it knows.
thus, even using _ at the top level would be a bad idea: the composer.json would not validate against the schema anymore (composer uses it in the lock file, which is not validated against a schema).