[Form] [Validator] Fix locale inconsistencies for Norwegian translations #17785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is bug fix, can you submit the same PR for the 2.3 branch? |
fabpot
added a commit
that referenced
this pull request
Feb 14, 2016
…an translations (valisj) This PR was merged into the 2.3 branch. Discussion ---------- [Form] [Validator] Fix locale inconsistencies in Norwegian translations | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | N/A | License | MIT See #17785 Commits ------- ab2ac93 [Form] [Validator] Fix locale inconsistencies in Norwegian translations
|
Thank you @valisj. |
fabpot
added a commit
that referenced
this pull request
Feb 14, 2016
…ian translations (valisj) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17785). Discussion ---------- [Form] [Validator] Fix locale inconsistencies for Norwegian translations | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | N/A | License | MIT Bokmål is the preferred written standard of Norwegian for 85% to 90% of the population of Norway. It is therefore not entirely correct that the current translation of English in Nynorsk is the default one (`no` locale) for the Validator component. This also creates inconsistency in Norwegian translations as other translations with the `no` locale are actually in Bokmål in the Form component, meaning that different written standards would be rendered in the same page. In this PR, the filenames for translations are changed in such a way that Bokmål will be the default translation for the `no` locale, and nynorsk for the `nn` locale. Renaming of `validators.nb.xlf` to `validators.no.xlf` (in Form component) will, however, lead to missing translations for those who relied on the `nb` locale for Bokmål. One solution is to have 2 exact translation files - validators.no.xlf and validators.nb.xlf - to avoid this problem. Renaming of `validators.no.xlf` (which is currently in Nynorsk `nn`) to `validators.nn.xlf` (in Validator component) must be done in order to make the relation between translation content and locales consistent. I don't think this will lead to any major problems, since people expect to have Bokmål as the default translation. Any thoughts? Commits ------- 67d343f Fix locale and written standard inconsistencies for Norwegian translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bokmål is the preferred written standard of Norwegian for 85% to 90% of the population of Norway. It is therefore not entirely correct that the current translation of English in Nynorsk is the default one (
nolocale) for the Validator component.This also creates inconsistency in Norwegian translations as other translations with the
nolocale are actually in Bokmål in the Form component, meaning that different written standards would be rendered in the same page.In this PR, the filenames for translations are changed in such a way that Bokmål will be the default translation for the
nolocale, and nynorsk for thennlocale.Renaming of
validators.nb.xlftovalidators.no.xlf(in Form component) will, however, lead to missing translations for those who relied on thenblocale for Bokmål. One solution is to have 2 exact translation files - validators.no.xlf and validators.nb.xlf - to avoid this problem.Renaming of
validators.no.xlf(which is currently in Nynorsknn) tovalidators.nn.xlf(in Validator component) must be done in order to make the relation between translation content and locales consistent. I don't think this will lead to any major problems, since people expect to have Bokmål as the default translation.Any thoughts?