8000 minor #17785 [Form] [Validator] Fix locale inconsistencies for Norweg… · symfony/symfony@10ba63c · GitHub
[go: up one dir, main page]
Skip to content

Commit 10ba63c

Browse files
fabpotfabpot
committed
minor #17785 [Form] [Validator] Fix locale inconsistencies for Norwegian translations (valisj)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17785). Discussion ---------- [Form] [Validator] Fix locale inconsistencies for Norwegian translations | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | N/A | License | MIT Bokmål is the preferred written standard of Norwegian for 85% to 90% of the population of Norway. It is therefore not entirely correct that the current translation of English in Nynorsk is the default one (`no` locale) for the Validator component. This also creates inconsistency in Norwegian translations as other translations with the `no` locale are actually in Bokmål in the Form component, meaning that different written standards would be rendered in the same page. In this PR, the filenames for translations are changed in such a way that Bokmål will be the default translation for the `no` locale, and nynorsk for the `nn` locale. Renaming of `validators.nb.xlf` to `validators.no.xlf` (in Form component) will, however, lead to missing translations for those who relied on the `nb` locale for Bokmål. One solution is to have 2 exact translation files - validators.no.xlf and validators.nb.xlf - to avoid this problem. Renaming of `validators.no.xlf` (which is currently in Nynorsk `nn`) to `validators.nn.xlf` (in Validator component) must be done in order to make the relation between translation content and locales consistent. I don't think this will lead to any major problems, since people expect to have Bokmål as the default translation. Any thoughts? Commits ------- 67d343f Fix locale and written standard inconsistencies for Norwegian translations
2 parents ec7b3f2 + 67d343f commit 10ba63c

File tree

4 files changed

+263
-263
lines changed

4 files changed

+263
-263
lines changed

‎src/Symfony/Component/Form/Resources/translations/validators.nb.xlf renamed to ‎src/Symfony/Component/Form/Resources/translations/validators.no.xlf

File renamed without changes.

‎src/Symfony/Component/Validator/Resources/translations/validators.nb.xlf

Lines changed: 0 additions & 155 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0