[PropertyInfo] Use last version of reflection docblock #17531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3249fd9 to
b4c1a17
Compare
|
Do you know when version 3.0 will be out? If it's going to be before 3.1, we can definitely merge this. |
|
I don't know :/, i ask them here phpDocumentor/ReflectionDocBlock#70 |
7 tasks
|
Stable release ok for phpdocblock 3.0 Ready to review poke @dunglas (i believe your are in charge of this component ?) |
|
@joelwurtz this PR needs a rebase. Also, it looks like phpdocumentor/reflection-docblock 3.0.0 was released. |
| }, | ||
| "conflict": { | ||
| "phpdocumentor/reflection": "<1.0.7" | ||
| "phpdocumentor/reflection": "<3.0" |
There was a problem hiding this comment.
you forgot to change the package name here
4251b83 to
6829b8a
Compare
|
Rebased and fix issues from feedback. 8000 |
| }, | ||
| "conflict": { | ||
| "phpdocumentor/reflection": "<1.0.7" | ||
| "phpdocumentor/reflection-docblock": "<3.0" |
There was a problem hiding this comment.
Do we really need this? I don't think so.
There was a problem hiding this comment.
I don't think also it make sense here as the suggest is only in the component not in main composer. However it can help user to know which version of this library is supported, but maybe not it's place in the main composer.
6829b8a to
d642eae
Compare
|
Rebased on master and fix feedback, what about the conflict in the master composer.json ? |
|
Thank you @joelwurtz. |
fabpot
added a commit
that referenced
this pull request
Feb 26, 2016
… (joelwurtz) This PR was merged into the 3.1-dev branch. Discussion ---------- [PropertyInfo] Use last version of reflection docblock | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR improve the PhpDocExtractor to use https://github.com/phpDocumentor/ReflectionDocBlock 3.0 dev branch instead of https://github.com/phpDocumentor/ReflectionDocBlock 1.0.7 which is not maintained since 2014 I don't know if it's a BC break since it's only a suggested dependency. This is somehow mandatory (we can maybe use a more stable, but also not maintained version of this repository) for #17516 as it does not have a dependency on php-parser 0.9.4 which is very old and not really suitable for the new component. Commits ------- d642eae Use last version of reflection dockblock, avoid extra dependancy if library needed
This was referenced Feb 26, 2016
fabpot
added a commit
that referenced
this pull request
Feb 28, 2016
…th the PHPDoc extractor (dunglas) This PR was merged into the 3.1-dev branch. Discussion ---------- [PropertyInfo] Allow to use a custom DocBlock factory with the PHPDoc extractor | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Minor tweak to #17531. Commits ------- 3c32a2f [PropertyInfo] Allow to use a custom DocBlock factory with the PHPDoc extractor
fabpot
added a commit
that referenced
this pull request
Feb 29, 2016
…ng reflection-docblock 3 (dunglas) This PR was squashed before being merged into the 3.1-dev branch (closes #17931). Discussion ---------- [FrameworkBundle] Fix PropertyInfo registration when using reflection-docblock 3 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Currently, the PHPDoc extractor of PropertyInfo is not registered anymore because #17531 was merged. Commits ------- 6d31365 [FrameworkBundle] Fix PropertyInfo registration when using reflection-docblock 3
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
…dunglas) This PR was merged into the 3.1-dev branch. Discussion ---------- [PropertyInfo] Fix a BC break when the DocBlock is empty | Q | A | ------------- | --- | Branch | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a BC break introduced by #17531. Commits ------- d2d8d17 [PropertyInfo] Fix a BC break when the DocBlock is empty
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve the PhpDocExtractor to use https://github.com/phpDocumentor/ReflectionDocBlock 3.0 dev branch instead of https://github.com/phpDocumentor/ReflectionDocBlock 1.0.7 which is not maintained since 2014
I don't know if it's a BC break since it's only a suggested dependency.
This is somehow mandatory (we can maybe use a more stable, but also not maintained version of this repository) for #17516 as it does not have a dependency on php-parser 0.9.4 which is very old and not really suitable for the new component.