Rename metadata interfaces and classes #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build with #433 - all Behat tests pass: https://travis-ci.org/teohhanhui/DunglasApiBundle/jobs/112816452 |
|
👍 looks good to me. Thanks for this tedious work. |
|
@teohhanhui can you resolve the few remaining conflicts? And the tests :) |
49662ff to
66b9c48
Compare
|
Rebased and updated as per #420 (comment) |
dunglas
added a commit
that referenced
this pull request
Mar 7, 2016
Rename metadata interfaces and classes
|
Thank you very much @teohhanhui |
|
@teohhanhui can you rename services accordingly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #420
Build is broken since symfony/symfony#17531