10000 fixed APCu dep version by fabpot · Pull Request #17524 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

fixed APCu dep version #17524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2016
Merged

fixed APCu dep version #17524

merged 1 commit into from
Jan 25, 2016

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jan 25, 2016
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17428
License MIT

@fabpot fabpot mentioned this pull request Jan 25, 2016
Closed
@Tobion
Copy link
Contributor
Tobion commented Jan 25, 2016

You forgot https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/ClassLoader/composer.json#L21

@fabpot
Copy link
Member Author
fabpot commented Jan 25, 2016

@Tobion fixed

@Tobion
Copy link
Contributor
Tobion commented Jan 25, 2016

Merging. Will also merge it upwards

@Tobion
Copy link
Contributor
Tobion commented Jan 25, 2016

Thank you @fabpot.

@Tobion Tobion merged commit 3b7f4c7 into symfony:2.3 Jan 25, 2016
Tobion added a commit that referenced this pull request Jan 25, 2016
@Tobion
minor #17524 fixed APCu dep version (fabpot)
d9f02fb 
This PR was merged into the 2.3 branch.

Discussion
----------

fixed APCu dep version

 Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17428
| License       | MIT

Commits
-------

3b7f4c7 fixed APCu dep version
@nicolas-grekas
Copy link
Member

@Tobion I read in a comment that polyfill-apcu could be removed in master because apc_* is pre-5.5 only, but this forgets about HHVM, which still provides apc_*

@Tobion
Copy link
Contributor
Tobion commented Jan 25, 2016

Hm but #17519 does not fail on hhvm on apcu?

@Tobion
Copy link
Contributor
Tobion commented Jan 25, 2016

Ah probably because it's skipped now?

@nicolas-grekas
Copy link
Member

I guess...

@stof
Copy link
Member
stof commented Jan 25, 2016

I suggest opening an issue on HHVM asking them to provide the apcu_* functions too

@nicolas-grekas
Copy link
Member

Done : facebook/hhvm#6784

@Tobion
Copy link
Contributor
Tobion commented Jan 25, 2016

So are we ok to just wait on hhvm support and add apcu-polyfill to the suggest section of the ClassLoader in the meantime? I saw that was done for the cache component.

@Tobion Tobion mentioned this pull request Jan 25, 2016
Merged
fabpot added a commit that referenced this pull request Jan 26, 2016
@fabpot
minor #17534 [ClassLoader] suggest apcu polyfill for hhvm (Tobion)
47677ae 
This PR was merged into the 3.0 branch.

Discussion
----------

[ClassLoader] suggest apcu polyfill for hhvm

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17524 (comment)
| License       | MIT
| Doc PR        | -

Same approach as in https://github.com/symfony/symfony/pull/17530/files#diff-877e1eb36c14b7b8dc89a910744ebfcdR31

Commits
-------

714fcc6 suggest apcu polyfill as apcu_* function are not yet available on hhvm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabpot @Tobion @nicolas-grekas @stof @carsonbot
0