8000 Use a simpler composer constraint for symfony/polyfill-apcu by GuilhemN · Pull Request #17428 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Use a simpler composer constraint for symfony/polyfill-apcu #17428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use a simpler composer constraint for symfony/polyfill-apcu #17428

wants to merge 1 commit into from

Conversation

GuilhemN
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

symfony/polyfill-apcu hasn't been released yet so we do not need this complex constraint.

ping @nicolas-grekas

@xabbuh
Copy link
Member
xabbuh commented Jan 19, 2016

The thing is that with the next release of the symfony/polyfill package (which will be 1.0.2) you will be able to require symfony/polyfill whenever you need symfony/polyfill-apcu as the meta-package has a replace for the APCu package with the same version number: https://github.com/symfony/polyfill/blob/master/composer.json#L25

Thus there would need to be three releases (1.0.0, 1.0.1, and 1.0.2) of the APCu polyfill package for the same commit to make that possible. To avoid these useless releases the first one can simply be 1.0.2.

By the way, we did the same with Symfony components in the past. For example, the first release of the VarDumper component was 2.6.0.

For these reasons, I am 👎 on this change.

@GuilhemN
Copy link
Contributor Author

This PR doesn't mean beginning the versioning of the apcu polyfill by 1.0.
The only thing is that the 1.0.2 constraint is useless (as 1.0.0 won't be released).

@xabbuh
Copy link
Member
xabbuh commented Jan 20, 2016

Sure, you are right.

👍

@stof
Copy link
Member
stof commented Jan 20, 2016

Btw, adding a new component cannot be a 1.0.2 release of symfony/polyfill. According to semver, we should release it as 1.1 (and then use ~1.1 here)

@GuilhemN
Copy link
Contributor Author

@stof should I update this PR or leave it as is as a reminder?

@fabpot
Copy link
Member
fabpot commented Jan 25, 2016

1.1.0 is out.

@xabbuh
Copy link
Member
xabbuh commented Jan 25, 2016

Status: Needs work

@GuilhemN
Copy link
Contributor Author

I won't be able to update this pr before next week so feel free to create a new one.

@fabpot fabpot mentioned this pull request Jan 25, 2016
Merged
@fabpot
Copy link
Member
fabpot commented Jan 25, 2016

#17524

@fabpot fabpot closed this Jan 25, 2016
Tobion added a commit that referenced this pull request Jan 25, 2016
@Tobion
minor #17524 fixed APCu dep version (fabpot)
d9f02fb 
This PR was merged into the 2.3 branch.

Discussion
----------

fixed APCu dep version

 Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17428
| License       | MIT

Commits
-------

3b7f4c7 fixed APCu dep version
@GuilhemN GuilhemN deleted the patch-2 branch January 26, 2016 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuilhemN @xabbuh @stof @fabpot @carsonbot
0