8000 [Serializer] Delegate complex caching in ObjectNormalizer to ClassMetadataFactory by nicolas-grekas · Pull Request #17333 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Delegate complex caching in ObjectNormalizer to ClassMetadataFactory #17333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Serializer] Delegate complex caching in ObjectNormalizer to ClassMetadataFactory #17333

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Possible alternative to #17199

@dunglas
Copy link
Member
dunglas commented Jan 11, 2016

👍 to delegate the caching to ClassMetadataFactory when applicable but IIUC this PR doesn't replace #17199. The following test will still fail: https://github.com/symfony/symfony/pull/17199/files#diff-383be450d98e45fa294e0527b2e44640R477

@dunglas
Copy link
Member
dunglas commented Jan 11, 2016

Btw, the ArrayCache implementation of Doctrine cache is significantly slower than the previous strategy (the simple array).

Here is a benchmark: #16838 (comment)

@nicolas-grekas nicolas-grekas deleted the ser-cache branch January 12, 2016 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Need 49F2 s Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @dunglas @carsonbot
0