8000 [Serializer] Allow context to contain not serializable data by dunglas · Pull Request #17199 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Allow context to contain not serializable data #17199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2016
Merged

[Serializer] Allow context to contain not serializable data #17199

merged 1 commit into from
Jan 12, 2016

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Dec 31, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Allow the context to contain not serializable data even for the ObjectNormalizer (BC break fix).

@dunglas dunglas changed the title [Serializer] Allow to contain not serializable data. [Serializer] Allow context to contain not serializable data Dec 31, 2015
@dunglas
Copy link
Member Author
dunglas commented Jan 11, 2016

Status: needs work

@nicolas-grekas nicolas-grekas mentioned this pull request Jan 11, 2016
Closed
@dunglas
Merge pull request #2 from nicolas-grekas/ser-cache
996f69d 
[Serializer] Use $context['cache_key'] to enhance caching
@nicolas-grekas
Copy link
Member

👍
Status: reviewed

@fabpot
Copy link
Member
fabpot commented Jan 12, 2016

Thank you @dunglas.

@fabpot fabpot merged commit 996f69d into symfony:2.8 Jan 12, 2016
fabpot added a commit that referenced this pull request Jan 12, 2016
@fabpot
bug #17199 [Serializer] Allow context to contain not serializable dat…
3331c8a 
…a (dunglas, nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[Serializer] Allow context to contain not serializable data

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Allow the context to contain not serializable data even for the `ObjectNormalizer` (BC break fix).

Commits
-------

996f69d Merge pull request #2 from nicolas-grekas/ser-cache
8560c13 [Serializer] Use $context['cache_key'] to enhance caching
c1740fc [Serializer] ObjectNormalizer: context can contain not serializable data
@fabpot fabpot mentioned this pull request Jan 14, 2016
Merged
@fabpot fabpot mentioned this pull request Feb 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @nicolas-grekas @fabpot @carsonbot
0