[HttpFoundation] Allow to get all the mime types associated to a format in the Request #17318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return array The associated mime types | ||
| */ | ||
| public function getMimeTypes($format) |
There was a problem hiding this comment.
👍 we should also update the other related functions in another PR IMO: setFormat, getMimeType and getFormat.
aa38636 to
0f3af7d
Compare
| $this->assertEquals($mimeTypes, Request::getMimeTypes($format)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think one more test could be useful, which asserts what getMimeTypes() returns, if the format is not found in Request::$formats.
There was a problem hiding this comment.
Good idea, added :-)
…at in the Request
|
👍 |
|
👍 |
|
👍 |
|
Thank you @Ener-Getick. |
fabpot
added a commit
that referenced
this pull request
Jan 14, 2016
…iated to a format in the Request (Ener-Getick) This PR was merged into the 3.1-dev branch. Discussion ---------- [HttpFoundation] Allow to get all the mime types associated to a format in the Request | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT This PR creates a new method in ``Request`` to allow to get all the mime types associated to a format. This is useful in the case of a format negotiator which needs to convert a list of format to a list of mime types (see [the ``FormatNegotiator`` of the ``FOSRestBundle``](https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/Negotiation/FormatNegotiator.php#L126)) Commits ------- 4618c9f [HttpFoundation] Allow to get all the mime types associated to a format in the Request
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new method in
Requestto allow to get all the mime types associated to a format.This is useful in the case of a format negotiator which needs to convert a list of format to a list of mime types (see the
FormatNegotiatorof theFOSRestBundle)