Test the format negotiator and reorganize it #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
does this mean that priorities now need to be mime types and we no longer support formats?
Member
Author
There was a problem hiding this comment.
Yes, for the moment I just removed it. I have to think how to replace this ...
Member
There was a problem hiding this comment.
ok .. we should then create a follow up ticket for this. its annoying that the Request class does not give access to the mappings in Request::formats.
/cc @Tobion
Member
Author
There was a problem hiding this comment.
We should maybe create an issue / a pr for symfony 2.8 or 3.0 to add a new method Request::getMimeTypes() and see what the symfony staff think about this.
lsmith77
added a commit
that referenced
this pull request
Oct 6, 2015
Test the format negotiator and reorganize it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a test for the
FormatNegotiator. Several mistakes are fixed.