8000 [DoctrineBridge][Form] Add old tests to legacy group by giosh94mhz · Pull Request #15536 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DoctrineBridge][Form] Add old tests to legacy group #15536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2015

Conversation

giosh94mhz
Copy link
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@fabpot this are the minor fixes required after merging PR #15251. You are already managed the duplicated class during merge, so only some @group legacy annotation were missing.

@stof
Copy link
Member
stof commented Aug 13, 2015

👍 (the remaining failure is a segfault in PHP7, which was already reported upstream)

@fabpot
Copy link
Member
fabpot commented Aug 13, 2015

Thank you @giosh94mhz.

@fabpot fabpot merged commit 724a54b into symfony:2.7 Aug 13, 2015
fabpot added a commit that referenced this pull request Aug 13, 2015
…osh94mhz)

This PR was merged into the 2.7 branch.

Discussion
----------

[DoctrineBridge][Form] Add old tests to legacy group

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

@fabpot this are the minor fixes required after merging PR  #15251. You are already managed the duplicated class during merge, so only some `@group legacy` annotation were missing.

Commits
-------

724a54b [DoctrineBridge][Form] Add old tests to legacy group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0