[DoctrineBridge][Form] Fix IdReader when indexing by primary foreign key #15251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9297c0f to
799d0e0
Compare
|
👍 |
|
fingers crossed that it will be merged soon ;) |
|
Thank you @giosh94mhz. |
fabpot
added a commit
that referenced
this pull request
Aug 12, 2015
…ry foreign key (giosh94mhz) This PR was merged into the 2.7 branch. Discussion ---------- [DoctrineBridge][Form] Fix IdReader when indexing by primary foreign key | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Port to Symfony 2.7 of PR #14372 . The `IdReader` class can now resolve association and determine the real id value. There is still room for improvement, though. Since I've added a `new IdReader` in the constructor, it is better to declare `IdReader` as `final` just to be safe. PS: sorry to keep you waiting, @webmozart . When merging both commit don't forget to add the `@deprecated` annotation, and that `SingleAssociationToIntIdEntity.php` is duplicated. Commits ------- 799d0e0 [DoctrineBridge][Form] Fix IdReader when indexing by primary foreign key
|
@giosh94mhz Can you make an additional PR now that both PRs are merged to manage the remaining changes? |
|
Thank you @fabpot. You mean the test class and the deprecated annotation? No problem, I'll do it ASAP. |
fabpot
added a commit
that referenced
this pull request
Aug 13, 2015
…osh94mhz) This PR was merged into the 2.7 branch. Discussion ---------- [DoctrineBridge][Form] Add old tests to legacy group | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | @fabpot this are the minor fixes required after merging PR #15251. You are already managed the duplicated class during merge, so only some `@group legacy` annotation were missing. Commits ------- 724a54b [DoctrineBridge][Form] Add old tests to legacy group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to Symfony 2.7 of PR #14372 . The
IdReaderclass can now resolve association and determine the real id value.There is still room for improvement, though. Since I've added a
new IdReaderin the constructor, it is better to declareIdReaderasfinaljust to be safe.PS: sorry to keep you waiting, @webmozart . When merging both commit don't forget to add the
@deprecatedannotation, and thatSingleAssociationToIntIdEntity.phpis duplicated.