10000 [Translation][Form][choice] empty_value shouldn't be translated when it has an empty value by Restless-ET · Pull Request #15048 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation][Form][choice] empty_value shouldn't be translated when it has an empty value #15048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Translation][Form][choice] empty_value shouldn't be translated when it has an empty value #15048

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f9d2af
'empty_value' should not be translated when empty.
Restless-ET Jun 16, 2015
e585273
Removed translation when 'empty_value' option has an empty value at P…
Restless-ET Jun 16, 2015
d68c8cd
Fixed form abstract layout tests to consider that empty placeholders …
Restless-ET Jun 16, 2015
6cc211b
Applied the suggested improvements.
Restless-ET Jun 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
'empty_value' should not be translated when empty.
  • Loading branch information
@Restless-ET
Restless-ET committed Jun 27, 2015
commit 0f9d2af86c6b4c33174d37f298d7790f68f36f91
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
{%- endif -%}
<select {{ block('widget_attributes') }}{% if multiple %} multiple="multiple"{% endif %}>
{%- if empty_value is not none -%}
<option value=""{% if required and value is empty %} selected="selected"{% endif %}>{{ empty_value|trans({}, translation_domain) }}</option>
<option value=""{% if required and value is empty %} selected="selected"{% endif %}>{{ empty_value is empty ? empty_value : empty_value|trans({}, translation_domain) }}</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when empty_value is empty, there is no point it outputting it. so you can do {{ empty_value is not empty ? empty_value|trans({}, translation_domain) }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same problem in php template

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also since we know that empty_value can only be a string at this point (not an array for example), we can just do {{ empty_value != '' ? empty_value|trans({}, translation_domain) }}

{%- endif -%}
{%- if preferred_choices|length > 0 -%}
{% set options = preferred_choices %}
Expand Down
0