[Translation][Form][choice] empty_value shouldn't be translated when it has an empty value #15048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 ping @symfony/deciders |
| @@ -7,7 +7,7 @@ | |||
| )) ?> | |||
| <?php if ($multiple): ?> multiple="multiple"<?php endif ?> | |||
| > | |||
| <?php if (null !== $empty_value): ?><option value=""<?php if ($required and empty($value) && '0' !== $value): ?> selected="selected"<?php endif?>><?php echo $view->escape($view['translator']->trans($empty_value, array(), $translation_domain)) ?></option><?php endif; ?> | |||
| <?php if (null !== $empty_value): ?><option value=""<?php if ($required and empty($value) && '0' !== $value): ?> selected="selected"<?php endif?>><?php echo empty($empty_value) ? $empty_value : $view->escape($view['translator']->trans($empty_value, array(), $translation_domain)) ?></option><?php endif; ?> | |||
There was a problem hiding this comment.
php empty() also return true for '0' which is not what we want (and which is not equivalent to the twig empty test). so you need to test if ('' == $empty_value) instead
1 task
|
👍 |
|
@Restless-ET Can you rebase this PR on 2.3 to get rid of the merge commit? |
|
👍 |
…HP templating engine.
…('empty_value' option) are no longer translated.
ad77418 to
6cc211b
Compare
|
Thank you @Restless-ET. |
Tobion
added a commit
that referenced
this pull request
Jun 27, 2015
…lated when it has an empty value (Restless-ET) This PR was squashed before being merged into the 2.3 branch (closes #15048). Discussion ---------- [Translation][Form][choice] empty_value shouldn't be translated when it has an empty value | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The same fix provided at #14997 but against ```2.3``` branch. @webmozart As requested. :) Commits ------- 1a5c4c6 [Translation][Form][choice] empty_value shouldn't be translated when it has an empty value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same fix provided at #14997 but against
2.3branch.@webmozart As requested. :)