8000 [Serializer] Fix a bug when using groups together with a name converter by dunglas · Pull Request #14415 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Fix a bug when using groups together with a name converter #14415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Serializer] Fix a bug when using groups together with a name converter #14415

wants to merge 2 commits into from

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Apr 20, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
  • Fix the bug
  • Increase test coverage

@dunglas dunglas self-assigned this Apr 20, 2015
xabbuh
xabbuh reviewed Apr 20, 2015
View reviewed changes
src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php
'foo_bar' => '@dunglas',
'symfony' => '@coopTilleuls',
),
$this->normalizer->normalize($obj, null, array('groups' => ['name_converter']))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short array notation is not supported by PHP 5.3.

@xabbuh
Copy link
Member
xabbuh commented Apr 20, 2015

The failing tests in the Translation component don't seem to be related to your changes, but a rebase might fix that.

@dunglas dunglas force-pushed the serializer_nc_groups branch from c7719cc to ae7ba6b Compare April 21, 2015 04:53
@dunglas
Copy link
Member Author
dunglas commented Apr 21, 2015

Removed the short array notation (it became a reflex) and rebased.

@dunglas
Copy link
Member Author
dunglas commented Apr 21, 2015

ping @symfony/deciders

@dunglas dunglas mentioned this pull request Apr 21, 2015
Closed
@dunglas dunglas force-pushed the serializer_nc_groups branch from ae7ba6b to cf27a1d Compare April 27, 2015 07:45
@dunglas
Copy link
Member Author
dunglas commented Apr 27, 2015

ping @symfony/deciders. I'll want to include this fix in the next release.

@fabpot
Copy link
Member
fabpot commented Apr 27, 2015

Thank you @dunglas.

@fabpot fabpot closed this in 09cde7c Apr 27, 2015
@dunglas dunglas deleted the serializer_nc_groups branch December 5, 2015 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dunglas dunglas

Labels
Bug Serializer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @xabbuh @fabpot
0