Removed deprecations in Serializer component #14151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| /** | ||
| * @group legacy | ||
| */ | ||
| public function testLegacyCamelizedAttributesNormalize() |
There was a problem hiding this comment.
If you just remove the test, we loose a test proving that name converters are supported and really used by the normalizer.
IMO this test should be converted to use directly the NameConverter instead of setCamelizedAttributes() but not totally removed.
Same for the other normalizer.
There was a problem hiding this comment.
The test should have been added when the deprecation was introduced, if the case it not covered anymore without using the deprecated way.
There was a problem hiding this comment.
@Tobion I'll open a PR for that.
|
I've added tests in #14415. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @dosten. |
dunglas
added a commit
that referenced
this pull request
Apr 27, 2015
This PR was squashed before being merged into the master branch (closes #14151). Discussion ---------- Removed deprecations in Serializer component | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- e90e9b2 Removed deprecations in Serializer component
615A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.