8000 [FrameworkBundle][Translation] skip warmUp when cache is not used. by aitboudad · Pull Request #14301 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle][Translation] skip warmUp when cache is not used. #14301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2015
Merged

[FrameworkBundle][Translation] skip warmUp when cache is not used. #14301

merged 1 commit into from
Apr 27, 2015

Conversation

aitboudad
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #13942
Tests pass? yes
License MIT

aitboudad referenced this pull request Apr 10, 2015
@xavierleune
FIX #13919 added TranslationsCacheWarmer to generate catalogues at wa…
94d3876 
…rmup
mpdude
mpdude reviewed Apr 10, 2015
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Translation/Translator.php
@@ -77,9 +77,18 @@ public function __construct(ContainerInterface $container, MessageSelector $sele
*/
public function warmUp($cacheDir)
{
// skip warmUp when translator doesn't use cache
if (!$currentDir = $this->options['cache_dir']) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$currentDir makes no sense here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@aitboudad aitboudad force-pushed the translation_warmup_fix branch from f315394 to 48f5253 Compare April 10, 2015 11:57
@aitboudad aitboudad changed the title [FrameworkBundle][Translation][warmUp] use tmp cacheDir. [WIP][FrameworkBundle][Translation][warmUp] use tmp cacheDir. Apr 15, 2015
@aitboudad aitboudad force-pushed the translation_warmup_fix branch from 48f5253 to b0a49e3 Compare April 24, 2015 09:10
@aitboudad aitboudad changed the title [WIP][FrameworkBundle][Translation][warmUp] use tmp cacheDir. [FrameworkBundle][Translation] skip warmUp when cache is not used. Apr 24, 2015
@aitboudad aitboudad force-pushed the translation_warmup_fix branch from b0a49e3 to efb10f6 Compare April 25, 2015 12:25
@aitboudad aitboudad merged commit efb10f6 into symfony:2.7 Apr 27, 2015
aitboudad added a commit that referenced this pull request Apr 27, 2015
@aitboudad
bug #14301 [FrameworkBundle][Translation] skip warmUp when cache is n…
f85ba5d 
…ot used. (aitboudad)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle][Translation] skip warmUp when cache is not used.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | #13942
| Tests pass?   | yes
| License       | MIT

Commits
-------

efb10f6 [FrameworkBundle][Translation] skip warmUp when cache is not used.
@aitboudad aitboudad deleted the translation_warmup_fix branch April 27, 2015 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FrameworkBundle Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitboudad @mpdude
0