8000 Translator : Retrieve every locales avalaible · Issue #13919 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Translator : Retrieve every locales avalaible #13919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xavierleune opened this issue Mar 13, 2015 · 0 comments
Closed

Translator : Retrieve every locales avalaible #13919

xavierleune opened this issue Mar 13, 2015 · 0 comments
Labels
Translation

Comments

@xavierleune
Copy link
Contributor

Hi,

I'm concerned about having no file generated in cache folder at runtime. My last problem is about the translation catalogues which are lazy loaded.
In fact I've read many lines of code and many issues about translator, there is actually no way to retrieve the list of locales.
Actually my idea is to add an optionnal entry to the "framework" conf key, to list available locales. If this entry is filled, it would be easy to run Translator::getCatalogue in a cache warmer. It means no BC Break and like other cache in symfony, the actual working would remain this one : if the cache file exists, load it. If not, create it and load it.

This patch is easy to do and I would be glad to do it, but I want to have your point of view before submitting my PR.

What do you think about it ?
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 16, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
60a74bb 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 16, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
0932ce1 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 16, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
050b8b4 
…s at warmup
@xavierleune xavierleune mentioned this issue Mar 16, 2015
Merged
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 17, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
f2c0226 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 17, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
57cd942 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 23, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
c56d47c 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 24, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
93b0f0c 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 24, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
ebc84cb 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 24, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
df1e752 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 24, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
a83a7dd 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 26, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
5000800 
…s at warmup
aitboudad pushed a commit to aitboudad/symfony that referenced this issue Mar 29, 2015
@xavierleune @aitboudad
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
4759543 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 30, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
d1015db 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 31, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
f5f8395 
…s at warmup
xavierleune added a commit to xavierleune/symfony that referenced this issue Mar 31, 2015
@xavierleune
FIX symfony#13919 added TranslationsCacheWarmer to generate catalogue…
58799d0 
…s at warmup
aitboudad added a commit that referenced this issue Apr 3, 2015
@aitboudad
feature #13942 [2.7][Translation] generate translation cache at warmu…
ce3b8fd 
…p (xavierleune)

This PR was merged into the 2.7 branch.

Discussion
----------

[2.7][Translation] generate translation cache at warmup

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13919
| License       | MIT
| Doc PR        | NA

This PR uses the parameters "locale" and "fallback_locales" to generate the catalogues at warmup, avoiding the creation of files at runtime.

Commits
-------

94d3876 FIX #13919 added TranslationsCacheWarmer to generate catalogues at warmup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aitboudad @xavierleune
0