8000 [Config] Delegate creation of ConfigCache instances to a factory. by mpdude · Pull Request #14178 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Delegate creation of ConfigCache instances to a factory. #14178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

[Config] Delegate creation of ConfigCache instances to a factory. #14178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
02159ae
Delegate creation of ConfigCache instances to a factory.
mpdude Apr 2, 2015
98aa48b
Fix wrong method name
mpdude Apr 2, 2015
3744edf
Add E_USER_DEPRECATED warning
mpdude Apr 2, 2015
282a75a
CS fix
mpdude Apr 2, 2015
ae29b82
CS fixes
mpdude Apr 2, 2015
1730fc3
Remove "constructor" docblocks
mpdude Apr 2, 2015
770ee09
DocBlock fixes
mpdude Apr 2, 2015
2a058fd
Fix DocBlock
mpdude Apr 2, 2015
8491dfd
Fix deprecation warnings
mpdude Apr 2, 2015
beb307c
Fix unnecessary re-initialization from cache
mpdude Apr 2, 2015
dbec920
Add deprecation notice in UPGRADE-2.7
mpdude Apr 4, 2015
5a91716
Tests need a recent version of the Config component
mpdude Apr 4, 2015
f2c3a24
Explicitly add symfony/config dependency in an desperate attempt to m…
mpdude Apr 4, 2015
35488bd
Suggestions from GH
mpdude Apr 5, 2015
17a55ec
FabBot compliance
mpdude Apr 6, 2015
07ecf57
Bump composer dep
mpdude Apr 6, 2015
a89db7a
As in aa82fb065d970c1fd02bf35790e4da8970f45e7b
mpdude Apr 6, 2015
7938349
Update composer.json
mpdude Apr 6, 2015
cb9917f
Don't mess with composer.json where it is not necessary
mpdude Apr 7, 2015
2016537
The HttpKernel for sure depends on the Config component
mpdude Apr 7, 2015
beb0a92
Cleanup composer.json
mpdude Apr 7, 2015
afee2bb
Make sure at least symfony/config 2.7 is installed when loaded as a t…
mpdude Apr 7, 2015
4832e1a
symfony/config dev-master cannot be used unless changes from this PR …
mpdude Apr 7, 2015
7f90bae
Grammar fix in comment
mpdude Apr 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explicitly add symfony/config dependency in an desperate attempt to m… 
…ake tests pass.

See for example https://travis-ci.org/symfony/symfony/jobs/57160322 - wrong (too low) versions of symfony/config are installed.
  • Loading branch information
@mpdude
mpdude committed Apr 6, 2015
commit f2c3a2456845c58e47516cbfaf972d96b468c035
1 change: 1 addition & 0 deletions src/Symfony/Bundle/FrameworkBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"symfony/phpunit-bridge": "~2.7|~3.0.0",
"symfony/browser-kit": "~2.4|~3.0.0",
"symfony/console": "~2.6|~3.0.0",
"symfony/config": "~2.7|~3.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot is it right to add these? Otherwise a too low version of symfony/config is installed.

"symfony/css-selector": "~2.0,>=2.0.5|~3.0.0",
"symfony/dom-crawler": "~2.0,>=2.0.5|~3.0.0",
"symfony/finder": "~2.0,>=2.0.5|~3.0.0",
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bundle/SecurityBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"symfony/validator": "~2.5|~3.0.0",
"symfony/yaml": "~2.0,>=2.0.5|~3.0.0",
"symfony/expression-language": "~2.6|~3.0.0",
"symfony/config": "~2.7|~3.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this as well.

"doctrine/doctrine-bundle": "~1.2",
"twig/twig": "~1.12",
"ircmaxell/password-compat": "~1.0"
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Routing/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"require-dev": {
"symfony/phpunit-bridge": "~2.7|~3.0.0",
"symfony/config": "~2.2|~3.0.0",
"symfony/config": "~2.7|~3.0.0",
"symfony/http-foundation": "~2.3|~3.0.0",
"symfony/yaml": "~2.0,>=2.0.5|~3.0.0",
"symfony/expression-language": "~2.4|~3.0.0",
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Security/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"symfony/routing": "~2.2|~3.0.0",
"symfony/translation": "~2.0,>=2.0.5|~3.0.0",
"symfony/validator": "~2.5,>=2.5.5|~3.0.0",
"symfony/config": "~2.7|~3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead, we should add a conflict rule for this:

{
    "...": "",
    "conflict": {
        "symfony/config": "<2.7"
    }
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in other occurences where you introduce a new config dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether I should add these at all. The Security component itself neither depends or conflicts with symfony/config. Its just that for some tests the Config component is installed as a transitive dependency (probably of symfony/http-kernel) and the version is too low.

I am very unsure about this, but I suspect that once this PR has been merged into the 2.7 branch and the raised dependency for symfony/config ~2.7 in the HttpKernel component has been picked up, we can drop this altogether?

Any advice appreciated.

"doctrine/common": "~2.2",
"doctrine/dbal": "~2.2",
"psr/log": "~1.0",
Expand Down
0