-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Config] Delegate creation of ConfigCache instances to a factory. #14178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
02159ae
98aa48b
3744edf
282a75a
ae29b82
1730fc3
770ee09
2a058fd
8491dfd
beb307c
dbec920
5a91716
f2c3a24
35488bd
17a55ec
07ecf57
a89db7a
7938349
cb9917f
2016537
beb0a92
afee2bb
4832e1a
7f90bae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ interface ConfigCacheFactoryInterface | |
* | ||
* @param string $file The absolute cache file path | ||
* @param callable $callable The callable to be executed when the cache needs to be filled (i. e. is not fresh). The cache will be passed as the only parameter to this callback. | ||
* | ||
* @return ConfigCacheInterface $configCache The cache instance. | ||
*/ | ||
public function cache($file, $callable); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we need to change file argument name here and to make it more generic. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what about There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know... I did not intend to change the way |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing line break