[DX]|Validator] Add PHPUnit hint in AbstractConstraintValidatorTest #14059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc2e62e to
11927b4
Compare
| @@ -244,7 +244,7 @@ protected function expectValidateValueAt($i, $propertyPath, $value, $constraints | |||
|
|
|||
| protected function assertNoViolation() | |||
| { | |||
| $this->assertCount(0, $this->context->getViolations()); | |||
| $this->assertSame(0, $violationsCount = count($this->context->getViolations()), sprintf('0 violation expected. Got %d.', $violationsCount)); | |||
There was a problem hiding this comment.
Wouldn't it be enough to add a message as the third parameter when calling assertCount()?
There was a problem hiding this comment.
But I will not be able to get the "real" (ie not expected) count.
There was a pro 8000 blem hiding this comment.
I don't understand what you mean. The output will be something like this:
Expected no violations.
Failed asserting that actual size 1 matches expected size 0.
Isn't that clear enough?
There was a problem hiding this comment.
Ok, I understand what you mean. But in order to keep consistency between both "assertion", I think It's better to keep a "long" message:
1) SensioLabs\Bundle\MyBundle\Tests\Validator\Constraints\ProjectRepositoryUrlValidatorTest::testInternalRepositoryCanBeEmptyInitially
1 violation(s) expected. Got 0.
Failed asserting that 0 is identical to 1.
/home/greg/dev/github.com/sensiolabs/my_project/vendor/symfony/symfony/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php:420
/home/greg/dev/github.com/sensiolabs/my_project/src/SensioLabs/Bundle/MyBundle/Tests/Validator/Constraints/ProjectRepositoryUrlValidatorTest.php:60
/home/greg/dev/github.com/sebastianbergmann/phpunit/src/TextUI/Command.php:151
/home/greg/dev/github.com/sebastianbergmann/phpunit/src/TextUI/Command.php:103
2) SensioLabs\Bundle\MyBundle\Tests\Validator\Constraints\ProjectRepositoryUrlValidatorTest::testInternalRepositoryCannotBeEmptyAfterFirstSync
0 violation expected. Got 1.
Failed asserting that 1 is identical to 0.
/home/greg/dev/github.com/sensiolabs/my_project/vendor/symfony/symfony/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php:247
/home/greg/dev/github.com/sensiolabs/my_project/src/SensioLabs/Bundle/MyBundle/Tests/Validator/Constraints/ProjectRepositoryUrlValidatorTest.php:72
/home/greg/dev/github.com/sebastianbergmann/phpunit/src/TextUI/Command.php:151
/home/greg/dev/github.com/sebastianbergmann/phpunit/src/TextUI/Command.php:103
When one extends AbstractConstraintValidatorTest, If test fails the output is not very easy to understand because all "magic" is done in the parent class. So we have to read the code of the parent class to understand what happened.
11927b4 to
bebca0b
Compare
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Mar 26, 2015
…lidatorTest (lyrixx) This PR was merged into the 2.7 branch. Discussion ---------- [DX]|Validator] Add PHPUnit hint in AbstractConstraintValidatorTest | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | ~ | License | MIT When one extends AbstractConstraintValidatorTest, If test fails the output is not very easy to understand because all "magic" is done in the parent class. So we have to read the code of the parent class to understand what happened. Commits ------- bebca0b |Validator] Add PHPUnit hint in AbstractConstraintValidatorTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one extends AbstractConstraintValidatorTest, If test fails
the output is not very easy to understand because all "magic"
is done in the parent class. So we have to read the code of the
parent class to understand what happened.