minor #14059 [DX]|Validator] Add PHPUnit hint in AbstractConstraintValidatorTest (lyrixx)

fabpot · fabpot · commit b9836b20dd1c · 2015-03-26T13:40:19.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [DX]|Validator] Add PHPUnit hint in AbstractConstraintValidatorTest | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | ~ | License | MIT When one extends AbstractConstraintValidatorTest, If test fails the output is not very easy to understand because all "magic" is done in the parent class. So we have to read the code of the parent class to understand what happened. Commits ------- bebca0b |Validator] Add PHPUnit hint in AbstractConstraintValidatorTest
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php
@@ -244,7 +244,7 @@ protected function expectValidateValueAt($i, $propertyPath, $value, $constraints
 
     protected function assertNoViolation()
     {
-        $this->assertCount(0, $this->context->getViolations());
+        $this->assertSame(0, $violationsCount = count($this->context->getViolations()), sprintf('0 violation expected. Got %u.', $violationsCount));
     }
 
     /**
@@ -417,7 +417,7 @@ public function assertRaised()
 
         $violations = iterator_to_array($this->context->getViolations());
 
-        \PHPUnit_Framework_Assert::assertCount(count($expected), $violations);
+        \PHPUnit_Framework_Assert::assertSame($expectedCount = count($expected), $violationsCount = count($violations), sprintf('%u violation(s) expected. Got %u.', $expectedCount, $violationsCount));
 
         reset($violations);
 

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ protected function expectValidateValueAt($i, $propertyPath, $value, $constraints`
`244`	`244`
`245`	`245`	`protected function assertNoViolation()`
`246`	`246`	`{`
`247`		`- $this->assertCount(0, $this->context->getViolations());`
	`247`	`+ $this->assertSame(0, $violationsCount = count($this->context->getViolations()), sprintf('0 violation expected. Got %u.', $violationsCount));`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`/**`
`@@ -417,7 +417,7 @@ public function assertRaised()`
`417`	`417`
`418`	`418`	`$violations = iterator_to_array($this->context->getViolations());`
`419`	`419`
`420`		`- \PHPUnit_Framework_Assert::assertCount(count($expected), $violations);`
	`420`	`+ \PHPUnit_Framework_Assert::assertSame($expectedCount = count($expected), $violationsCount = count($violations), sprintf('%u violation(s) expected. Got %u.', $expectedCount, $violationsCount));`
`421`	`421`
`422`	`422`	`reset($violations);`
`423`	`423`