Marked the ResolveParameterPlaceHoldersPassTest as legacy #13935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @fabpot @nicolas-grekas (There is one test failing =>
Failed asserting that false is true.) |
|
I think we need to split this in two test classes, one testing parameter resolution with the legacy interface, and one testing with the new interface. |
fcb855e to
0a3f60e
Compare
|
ping @nicolas-grekas : it's done. Is this what you meant ? |
|
|
||
| 8000 namespace Symfony\Component\DependencyInjection\Tests\Compiler; | ||
|
|
||
| class LegacyResolveParameterPlaceHoldersPassTest extends ResolveParameterPlaceHoldersPassTest |
There was a problem hiding this comment.
This setup is wrong: you are running all the ResolveParameterPlaceHoldersPassTest twice now: once for ResolveParameterPlaceHoldersPassTest and once for LegacyResolveParameterPlaceHoldersPassTest. LegacyResolveParameterPlaceHoldersPassTest should run only the legacy tests
74c589e to
52d7909
Compare
|
This PR must be reopen on 2.6 => #13941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last merge of 2.6 in 2.7, the tests are not ok. (a003380...17ad6fd)