8000 [OptionsResolver] add missing deprecation triggers by Tobion · Pull Request #13809 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[OptionsResolver] add missing deprecation triggers #13809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2015
Merged

[OptionsResolver] add missing deprecation triggers #13809

merged 2 commits into from
Feb 28, 2015

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Feb 27, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR -

@Tobion Tobion mentioned this pull request Feb 27, 2015
Merged
@Tobion Tobion changed the title [OptionsResolver] add missing deprecation triggers [WIP][OptionsResolver] add missing deprecation triggers Feb 27, 2015
@Tobion Tobion changed the title [WIP][OptionsResolver] add missing deprecation triggers [OptionsResolver] add missing deprecation triggers Feb 28, 2015
@stof
Copy link
Member
stof commented Feb 28, 2015

👍

Tobion
Tobion reviewed Feb 28, 2015
View reviewed changes
src/Symfony/Component/OptionsResolver/OptionsResolver.php
@@ -464,6 +466,8 @@ public function setAllowedValues($option, $allowedValues = null)

// BC
if (is_array($option) && null === $allowedValues) {
trigger_error('Calling the '.__METHOD__.' method with an array options is deprecated since version 2.6 and will be removed in 3.0. Use the new signature with a single option instead.', E_USER_DEPRECATED);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: array of options

@Tobion Tobion force-pushed the options-resolver-missing-trigger-deprecations branch from 627218c to 9607e82 Compare February 28, 2015 12:09
@Tobion Tobion merged commit 9607e82 into symfony:2.7 Feb 28, 2015
Tobion added a commit that referenced this pull request Feb 28, 2015
@Tobion
feature #13809 [OptionsResolver] add missing deprecation triggers (To…
c498389 
…bion)

This PR was merged into the 2.7 branch.

Discussion
----------

[OptionsResolver] add missing deprecation triggers

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | -

Commits
-------

9607e82 replace deprecated options resolver uses by new ones
7e9d2e6 [OptionsResolver] add missing deprecation triggers
@Tobion Tobion deleted the options-resolver-missing-trigger-deprecations branch February 28, 2015 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobion @stof
0