10000 feature #13809 [OptionsResolver] add missing deprecation triggers (To… · symfony/symfony@c498389 · GitHub
[go: up one dir, main page]
Skip to content

Commit c498389

Browse files
TobionTobion
committed
feature #13809 [OptionsResolver] add missing deprecation triggers (Tobion)
This PR was merged into the 2.7 branch. Discussion ---------- [OptionsResolver] add missing deprecation triggers | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - Commits ------- 9607e82 replace deprecated options resolver uses by new ones 7e9d2e6 [OptionsResolver] add missing deprecation triggers
2 parents 469e70d + 9607e82 commit c498389

17 files changed

+102
-140
lines changed

‎src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -175,14 +175,10 @@ public function configureOptions(OptionsResolver $resolver)
175175

176176
$resolver->setRequired(array('class'));
177177

178-
$resolver->setNormalizers(array(
179-
'em' => $emNormalizer,
180-
));
178+
$resolver->setNormalizer('em', $emNormalizer);
181179

182-
$resolver->setAllowedTypes(array(
183-
'em' => array('null', 'string', 'Doctrine\Common\Persistence\ObjectManager'),
184-
'loader' => array('null', 'Symfony\Bridge\Doctrine\Form\ChoiceList\EntityLoaderInterface'),
185-
));
180+
$resolver->setAllowedTypes('em', array('null', 'string', 'Doctrine\Common\Persistence\ObjectManager'));
181+
$resolver->setAllowedTypes('loader', array('null', 'Symfony\Bridge\Doctrine\Form\ChoiceList\EntityLoaderInterface'));
186182
}
187183

188184
/**

‎src/Symfony/Component/Form/Extension/Core/Type/BaseType.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ public function configureOptions(OptionsResolver $resolver)
123123
'auto_initialize' => true,
124124
));
125125

126-
$resolver->setAllowedTypes(array(
127-
'attr' => 'array',
128-
));
126+
$resolver->setAllowedTypes('attr', 'array');
129127
}
130128
}

‎src/Symfony/Component/Form/Extension/Core/Type/BirthdayType.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,9 @@ class BirthdayType extends AbstractType
2121
*/
2222
public function configureOptions(OptionsResolver $resolver)
2323
{
24-
$resolver->setDefaults(array(
25-
'years' => range(date('Y') - 120, date('Y')),
26-
));
24+
$resolver->setDefault('years', range(date('Y') - 120, date('Y')));
2725

28-
$resolver->setAllowedTypes(array(
29-
'years' => 'array',
30-
));
26+
$resolver->setAllowedTypes('years', 'array');
3127
}
3228

3329
/**

‎src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,10 @@ public function configureOptions(OptionsResolver $resolver)
233233
'data_class' => null,
234234
));
235235

236-
$resolver->setNormalizers(array(
237-
'empty_value' => $placeholderNormalizer,
238-
'placeholder' => $placeholderNormalizer,
239-
));
236+
$resolver->setNormalizer('empty_value', $placeholderNormalizer);
237+
$resolver->setNormalizer('placeholder', $placeholderNormalizer);
240238

241-
$resolver->setAllowedTypes(array(
242-
'choice_list' => array('null', 'Symfony\Component\Form\Extension\Core\ChoiceList\ChoiceListInterface'),
243-
));
239+
$resolver->setAllowedTypes('choice_list', array('null', 'Symfony\Component\Form\Extension\Core\ChoiceList\ChoiceListInterface'));
244240
}
245241

246242
/**

‎src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,7 @@ public function configureOptions(OptionsResolver $resolver)
9090
'delete_empty' => false,
9191
));
9292

93-
$resolver->setNormalizers(array(
94-
'options' => $optionsNormalizer,
95-
));
93+
$resolver->setNormalizer('options', $optionsNormalizer);
9694
}
9795

9896
/**

‎src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php

Lines changed: 24 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -253,32 +253,30 @@ public function configureOptions(OptionsResolver $resolver)
253253
'seconds',
254254
));
255255

256-
$resolver->setAllowedValues(array(
257-
'input' => array(
258-
'datetime',
259-
'string',
260-
'timestamp',
261-
'array',
262-
),
263 10000 -
'date_widget' => array(
264-
null, // inherit default from DateType
265-
'single_text',
266-
'text',
267-
'choice',
268-
),
269-
'time_widget' => array(
270-
null, // inherit default from TimeType
271-
'single_text',
272-
'text',
273-
'choice',
274-
),
275-
// This option will overwrite "date_widget" and "time_widget" options
276-
'widget' => array(
277-
null, // default, don't overwrite options
278-
'single_text',
279-
'text',
280-
'choice',
281-
),
256+
$resolver->setAllowedValues('input', array(
257+
'datetime',
258+
'string',
259+
'timestamp',
260+
'array',
261+
));
262+
$resolver->setAllowedValues('date_widget', array(
263+
null, // inherit default from DateType
264+
'single_text',
265+
'text',
266+
'choice',
267+
));
268+
$resolver->setAllowedValues('time_widget', array(
269+
null, // inherit default from TimeType
270+
'single_text',
271+
'text',
272+
'choice',
273+
));
274+
// This option will overwrite "date_widget" and "time_widget" options
275+
$resolver->setAllowedValues('widget', array(
276+
null, // default, don't overwrite options
277+
'single_text',
278+
'text',
279+
'choice',
282280
));
283281
}
284282

‎src/Symfony/Component/Form/Extension/Core/Type/DateType.php

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -224,31 +224,25 @@ public function configureOptions(OptionsResolver $resolver)
224224
'compound' => $compound,
225225
));
226226

227-
$resolver->setNormalizers(array(
228-
'empty_value' => $placeholderNormalizer,
229-
'placeholder' => $placeholderNormalizer,
227+
$resolver->setNormalizer('empty_value', $placeholderNormalizer);
228+
$resolver->setNormalizer('placeholder', $placeholderNormalizer);
229+
230+
$resolver->setAllowedValues('input', array(
231+
'datetime',
232+
'string',
233+
'timestamp',
234+
'array',
230235
));
231-
232-
$resolver->setAllowedValues(array(
233-
'input' => array(
234-
'datetime',
235-
'string',
236-
'timestamp',
237-
'array',
238-
),
239-
'widget' => array(
240-
'single_text',
241-
'text',
242-
'choice',
243-
),
236+
$resolver->setAllowedValues('widget', array(
237+
'single_text',
238+
'text',
239+
'choice',
244240
));
245241

246-
$resolver->setAllowedTypes(array(
247-
'format' => array('int', 'string'),
248-
'years' => 'array',
249-
'months' => 'array',
250-
'days' => 'array',
251-
));
242+
$resolver->setAllowedTypes('format', array('int', 'string'));
243+
$resolver->setAllowedTypes('years', 'array');
244+
$resolver->setAllowedTypes('months', 'array');
245+
$resolver->setAllowedTypes('days', 'array');
252246
}
253247

254248
/**

‎src/Symfony/Component/Form/Extension/Core/Type/FormType.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,7 @@ public function configureOptions(OptionsResolver $resolver)
209209
'post_max_size_message' => 'The uploaded file was too large. Please try to upload a smaller file.',
210210
));
211211

212-
$resolver->setAllowedTypes(array(
213-
'label_attr' => 'array',
214-
));
212+
$resolver->setAllowedTypes('label_attr', 'array');
215213
}
216214

217215
/**

‎src/Symfony/Component/Form/Extension/Core/Type/IntegerType.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,14 @@ public function configureOptions(OptionsResolver $resolver)
4545
'compound' => false,
4646
));
4747

48-
$resolver->setAllowedValues(array(
49-
'rounding_mode' => array(
50-
IntegerToLocalizedStringTransformer::ROUND_FLOOR,
51-
IntegerToLocalizedStringTransformer::ROUND_DOWN,
52-
IntegerToLocalizedStringTransformer::ROUND_HALF_DOWN,
53-
IntegerToLocalizedStringTransformer::ROUND_HALF_EVEN,
54-
IntegerToLocalizedStringTransformer::ROUND_HALF_UP,
55-
IntegerToLocalizedStringTransformer::ROUND_UP,
56-
IntegerToLocalizedStringTransformer::ROUND_CEILING,
57-
),
48+
$resolver->setAllowedValues('rounding_mode', array(
49+
IntegerToLocalizedStringTransformer::ROUND_FLOOR,
50+
IntegerToLocalizedStringTransformer::ROUND_DOWN,
51+
IntegerToLocalizedStringTransformer::ROUND_HALF_DOWN,
52+
IntegerToLocalizedStringTransformer::ROUND_HALF_EVEN,
53+
IntegerToLocalizedStringTransformer::ROUND_HALF_UP,
54+
IntegerToLocalizedStringTransformer::ROUND_UP,
55+
IntegerToLocalizedStringTransformer::ROUND_CEILING,
5856
));
5957
}
6058

‎src/Symfony/Component/Form/Extension/Core/Type/NumberType.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,14 @@ public function configureOptions(OptionsResolver $resolver)
4343
'compound' => false,
4444
));
4545

46-
$resolver->setAllowedValues(array(
47-
'rounding_mode' => array(
48-
NumberToLocalizedStringTransformer::ROUND_FLOOR,
49-
NumberToLocalizedStringTransformer::ROUND_DOWN,
50-
NumberToLocalizedStringTransformer::ROUND_HALF_DOWN,
51-
NumberToLocalizedStringTransformer::ROUND_HALF_EVEN,
52-
NumberToLocalizedStringTransformer::ROUND_HALF_UP,
53-
NumberToLocalizedStringTransformer::ROUND_UP,
54-
NumberToLocalizedStringTransformer::ROUND_CEILING,
55-
),
46+
$resolver->setAllowedValues('rounding_mode', array(
47+
NumberToLocalizedStringTransformer::ROUND_FLOOR,
48+
NumberToLocalizedStringTransformer::ROUND_DOWN,
49+
NumberToLocalizedStringTransformer::ROUND_HALF_DOWN,
50+
NumberToLocalizedStringTransformer::ROUND_HALF_EVEN,
51+
NumberToLocalizedStringTransformer::ROUND_HALF_UP,
52+
NumberToLocalizedStringTransformer::ROUND_UP,
53+
NumberToLocalizedStringTransformer::ROUND_CEILING,
5654
));
5755
}
5856

‎src/Symfony/Component/Form/Extension/Core/Type/PercentType.php

Lines changed: 3 additions & 5 deletions
Orig 10000 inal file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@ public function configureOptions(OptionsResolver $resolver)
3737
'compound' => false,
3838
));
3939

40-
$resolver->setAllowedValues(array(
41-
'type' => array(
42-
'fractional',
43-
'integer',
44-
),
40+
$resolver->setAllowedValues('type', array(
41+
'fractional',
42+
'integer',
4543
));
4644
}
4745

‎src/Symfony/Component/Form/Extension/Core/Type/RepeatedType.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,9 @@ public function configureOptions(OptionsResolver $resolver)
5656
'error_bubbling' => false,
5757
));
5858

59-
$resolver->setAllowedTypes(array(
60-
'options' => 'array',
61-
'first_options' => 'array',
62-
'second_options' => 'array',
63-
));
59+
$resolver->setAllowedTypes('options', 'array');
60+
$resolver->setAllowedTypes('first_options', 'array');
61+
$resolver->setAllowedTypes('second_options', 'array');
6462
}
6563

6664
/**

‎src/Symfony/Component/Form/Extension/Core/Type/TimeType.php

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -214,30 +214,24 @@ public function configureOptions(OptionsResolver $resolver)
214214
'compound' => $compound,
215215
));
216216

217-
$resolver->setNormalizers(array(
218-
'empty_value' => $placeholderNormalizer,
219-
'placeholder' => $placeholderNormalizer,
217+
$resolver->setNormalizer('empty_value', $placeholderNormalizer);
218+
$resolver->setNormalizer('placeholder', $placeholderNormalizer);
219+
220+
$resolver->setAllowedValues('input', array(
221+
'datetime',
222+
'string',
223+
'timestamp',
224+
'array',
220225
));
221-
222-
$resolver->setAllowedValues(array(
223-
'input' => array(
224-
'datetime',
225-
'string',
226-
'timestamp',
227-
'array',
228-
),
229-
'widget' => array(
230-
'single_text',
231-
'text',
232-
'choice',
233-
),
226+
$resolver->setAllowedValues('widget', array(
227+
'single_text',
228+
'text',
229+
'choice',
234230
));
235231

236-
$resolver->setAllowedTypes(array(
237-
'hours' => 'array',
238-
'minutes' => 'array',
239-
'seconds' => 'array',
240-
));
232+
$resolver->setAllowedTypes('hours', 'array');
233+
$resolver->setAllowedTypes('minutes', 'array');
234+
$resolver->setAllowedTypes('seconds', 'array');
241235
}
242236

243237
/**

‎src/Symfony/Component/Form/Extension/Core/Type/UrlType.php

< 3D24 span aria-hidden="true" class="f6 text-bold fgColor-danger">-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,9 @@ public function buildForm(FormBuilderInterface $builder, array $options)
3333
*/
3434
public function configureOptions(OptionsResolver $resolver)
3535
{
36-
$resolver->setDefaults(array(
37-
'default_protocol' => 'http',
38-
));
36+
$resolver->setDefault('default_protocol', 'http');
3937

40-
$resolver->setAllowedTypes(array(
41-
'default_protocol' => array('null', 'string'),
42-
));
38+
$resolver->setAllowedTypes('default_protocol', array('null', 'string'));
4339
}
4440

4541
/**

‎src/Symfony/Component/Form/Extension/Validator/Type/BaseValidatorExtension.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ public function configureOptions(OptionsResolver $resolver)
4949
'validation_groups' => null,
5050
));
5151

52-
$resolver->setNormalizers(array(
53-
'validation_groups' => $validationGroupsNormalizer,
54-
));
52+
$resolver->setNormalizer('validation_groups', $validationGroupsNormalizer);
5553
}
5654
}

‎src/Symfony/Component/Form/Extension/Validator/Type/FormTypeValidatorExtension.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ public function configureOptions(OptionsResolver $resolver)
7777
'extra_fields_message' => 'This form should not contain extra fields.',
7878
));
7979

80-
$resolver->setNormalizers(array(
81-
'constraints' => $constraintsNormalizer,
82-
));
80+
$resolver->setNormalizer('constraints', $constraintsNormalizer);
8381
}
8482

8583
/**

‎src/Symfony/Component/OptionsResolver/OptionsResolver.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,8 @@ public function setNormalizer($option, \Closure $normalizer)
428428
*/
429429
public function setNormalizers(array $normalizers)
430430
{
431+
trigger_error('The '.__METHOD__.' method is deprecated since version 2.6 and will be removed in 3.0. Use setNormalizer() instead.', E_USER_DEPRECATED);
432+
431433
foreach ($normalizers as $option => $normalizer) {
432434
$this->setNormalizer($option, $normalizer);
433435
}
@@ -464,6 +466,8 @@ public function setAllowedValues($option, $allowedValues = null)
464466

465467
// BC
466468
if (is_array($option) && null === $allowedValues) {
469+
trigger_error('Calling the '.__METHOD__.' method with an array of options is deprecated since version 2.6 and will be removed in 3.0. Use the new signature with a single option instead.', E_USER_DEPRECATED);
470+
467471
foreach ($option as $optionName => $optionValues) {
468472
$this->setAllowedValues($optionName, $optionValues);
469473
}
@@ -518,6 +522,8 @@ public function addAllowedValues($option, $allowedValues = null)
518522

519523
// BC
520524
if (is_array($option) && null === $allowedValues) {
525+
trigger_error('Calling the '.__METHOD__.' method with an array of options is deprecated since version 2.6 and will be removed in 3.0. Use the new signature with a single option instead.', E_USER_DEPRECATED);
526+
521527
foreach ($option as $optionName => $optionValues) {
522528
$this->addAllowedValues($optionName, $optionValues);
523529
}
@@ -570,6 +576,8 @@ public function setAllowedTypes($option, $allowedTypes = null)
570576

571577
// BC
572578
if (is_array($option) && null === $allowedTypes) {
579+
trigger_error('Calling the '.__METHOD__.' method with an array of options is deprecated since version 2.6 and will be removed in 3.0. Use the new signature with a single option instead.', E_USER_DEPRECATED);
580+
573581
foreach ($option as $optionName => $optionTypes) {
574582
$this->setAllowedTypes($optionName, $optionTypes);
575583
}
@@ -618,6 +626,8 @@ public function addAllowedTypes($option, $allowedTypes = null)
618626

619627
// BC
620628
if (is_array($option) && null === $allowedTypes) {
629+
trigger_error('Calling the '.__METHOD__.' method with an array of options is deprecated since version 2.6 and will be removed in 3.0. Use the new signature with a single option instead.', E_USER_DEPRECATED);
630+
621631
foreach ($option as $optionName => $optionTypes) {
622632
$this->addAllowedTypes($optionName, $optionTypes);
623633
}

0 commit comments

Comments
 (0)
0