8000 [Security] Fix expectation in a test. by jakzal · Pull Request #13738 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Fix expectation in a test. #13738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2015
Merged

[Security] Fix expectation in a test. #13738

merged 1 commit into from
Feb 21, 2015

Conversation

jakzal
Copy link
Contributor
@jakzal jakzal commented Feb 19, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This is related to #13466, which worked perfectly fine in 2.3. It breaks in 2.6 since we've changed the way we check for master request.

@jakzal
Copy link
Contributor Author
jakzal commented Feb 19, 2015

@nicolas-grekas components=low tests are failing on 2.6 for route descriptors, since case insensitive matching was introduced in #13567. Technically descriptors work with previous releases of the Routing component, so raising minimum requirement in the FrameworkBundle is probably not the best solution. I'm not sure how we could fix this, other than changing tests (maybe checking for a less specific value). Any suggestions?

@jakzal
Copy link
Contributor Author
jakzal commented Feb 20, 2015

ping @symfony/deciders

@fabpot
Copy link
Member
fabpot commented Feb 21, 2015

The while descriptor tests are annoying as they rely too much on the exact output. You're right in saying that bumping the dep version just to make those tests pass would be stupid and that's why I haven't fixed those tests yet. I don't have any good ideas except changing the tests (like we do elsewhere, we can probably have some placeholders in the fixtures to make the matching loose).

@fabpot
Copy link
Member
fabpot commented Feb 21, 2015

Thank you @jakzal.

@fabpot fabpot merged commit 8299a44 into symfony:2.6 Feb 21, 2015
fabpot added a commit that referenced this pull request Feb 21, 2015
@fabpot
minor #13738 [Security] Fix expectation in a test. (jakzal)
2d6fbc5 
This PR was merged into the 2.6 branch.

Discussion
----------

[Security] Fix expectation in a test.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is related to #13466, which worked perfectly fine in 2.3. It breaks in 2.6 since we've changed the way we check for master request.

Commits
-------

8299a44 [Security] Fix expectation in a test.
@jakzal jakzal mentioned this pull request Feb 21, 2015
Merged
@jakzal jakzal deleted the security-tests-fix branch September 26, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakzal @fabpot
0