8000 [FrameworkBundle] move Routing dep up to make tests pass by nicolas-grekas · Pull Request #13753 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] move Routing dep up to make tests pass #13753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2015
Merged

[FrameworkBundle] move Routing dep up to make tests pass #13753

merged 1 commit into from
Feb 22, 2015

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Ping @Tobion

@Tobion
Copy link
Contributor
Tobion commented Feb 21, 2015

This is ugly. I think we better rewrite the console descriptor tests to not test against the actual values but instead just the structure, e.g. with preg_match.
So in https://github.com/symfony/symfony/blob/2.6/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_1.md instead of Host Regex: #^localhost$#si it just tests Host Regex: .+

@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] fix tests compat with case sensitive hosts in Routing v2.3.0 [FrameworkBundle] move Routing dep up to make tests pass Feb 21, 2015
@nicolas-grekas
Copy link
Member Author

Hum, that's too much work. I updated the PR and took an other approach: raising composer deps a bit up.

@Tobion
Copy link
Contributor
Tobion commented Feb 21, 2015

This needs to be done in 2.3 branch.

@nicolas-grekas
Copy link
Member Author

Why is 2.3 green then ?

@Tobion
Copy link
Contributor
Tobion commented Feb 21, 2015

Ah nvm. The descriptors were added later.

@Tobion
Copy link
Contributor
Tobion commented Feb 21, 2015

👍

@jakzal
Copy link
Contributor
jakzal commented Feb 21, 2015

I was initially against raising the for the sake of making these tests pass, as technically the FrameworkBundle can work with previous versions of the Routing component.

However, now that I look at it, there's probably no use case for using FrameworkBundle without the whole stack and raising these deps doesn't make much harm. It still gives me a feeling we're postponing solving the issue.

So I'm +0.

@fabpot
Copy link
Member
fabpot commented Feb 22, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c71e2d5 into symfony:2.6 Feb 22, 2015
fabpot added a commit that referenced this pull request Feb 22, 2015
@fabpot
minor #13753 [FrameworkBundle] move Routing dep up to make tests pass…
51a2240 
… (nicolas-grekas)

This PR was merged into the 2.6 branch.

Discussion
----------

[FrameworkBundle] move Routing dep up to make tests pass

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Ping @Tobion

Commits
-------

c71e2d5 [FrameworkBundle] move Routing dep up to make tests pass
@nicolas-grekas nicolas-grekas deleted the fix-test branch February 22, 2015 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @Tobion @jakzal @fabpot
0