[Debug] generalize deprecated interfaces tracking #13665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13544 |
| License | MIT |
| Doc PR | - |
3fe2d96 to
e40a987
Compare
e40a987 to
bb6571e
Compare
| foreach ($refl->getInterfaceNames() as $interface) { | ||
| if (isset(self::$deprecated[$interface]) && ($len < 2 || strncmp($name, $interface, $len)) && !($parent && $parent->implementsInterface($interface))) { | ||
| trigger_error(sprintf('The %s %s %s that is deprecated %s', $name, $refl->isInterface() ? 'interface extends' : 'class implements', $interface, self::$deprecated[$interface]), E_USER_DEPRECATED); | ||
| } |
There was a problem hiding this comment.
Don't we have tests for that feature? It would make sense to have some.
bb6571e to
a756f5b
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2015
…olas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] generalize deprecated interfaces tracking | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13544 | License | MIT | Doc PR | - Commits ------- a756f5b [Debug] generalize deprecated interfaces tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.