8000 Better handling of implementation of deprecated interfaces · Issue #13544 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

Better handling of implementation of deprecated interfaces #13544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Jan 28, 2015 · 2 comments
Closed

Better handling of implementation of deprecated interfaces #13544

stof opened this issue Jan 28, 2015 · 2 comments
Labels
Debug Enhancement

Comments

@stof
Copy link
Member
stof commented Jan 28, 2015

Currently, the DebugClassLoader logs a warning for classes implementing a deprecated interface (or extending a deprecated class) but ignores classes in the Symfony namespace.
This is good for deprecations coming from Symfony, but not for any other project providing their own BC layer, as seen in twigphp/Twig#1612

A better solution would to skip the warning when the class is in the same root namespace than the interface (and taking care of PEAR-like convention for classes in the global namespace)

/cc @nicolas-grekas
@nicolas-grekas
Copy link
Member

I like it. A general rule is better than an exception.

@nicolas-grekas nicolas-grekas mentioned this issue Feb 12, 2015
Merged
@nicolas-grekas
Copy link
Member

Should be fixed by #13665

fabpot added a commit that referenced this issue Feb 12, 2015
@fabpot
feature #13665 [Debug] generalize deprecated interfaces tracking (nic…
74bdb8f 
…olas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Debug] generalize deprecated interfaces tracking

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13544
| License       | MIT
| Doc PR        | -

Commits
-------

a756f5b [Debug] generalize deprecated interfaces tracking
@fabpot fabpot closed this as completed Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Debug Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @nicolas-grekas @stof
0