8000 [Process] added a deprecation notice by fabpot · Pull Request #13600 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] added a deprecation notice #13600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2015
Merged

[Process] added a deprecation notice #13600

merged 1 commit into from
Feb 11, 2015

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Feb 5, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #12703, #12725
License MIT
Doc PR n/a

@fabpot fabpot mentioned this pull request Feb 5, 2015
Closed
nicolas-grekas
nicolas-grekas reviewed Feb 5, 2015
View reviewed changes
src/Symfony/Component/Process/Process.php
*
* @return self The current Process instance
*
* @throws LogicException In case the process is running
*
* @deprecated Passing an object as an input is deprecated since version 2.5 and will be removed in 3.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This marks the method itself as deprecated (that's how IDE will warn about it)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not look fixed. IDEs will still warn about using a deprecated method (there is no phpdoc to deprecate only a specific signature AFAIK)

@fabpot fabpot force-pushed the process-deprecations branch from 5bce1d3 to a923b1e Compare February 5, 2015 08:32
@xabbuh
Copy link
Member
xabbuh commented Feb 6, 2015

@fabpot I guess you also need to update some tests (at least the one using a Stringifiable instance as input).

@fabpot
Copy link
Member Author
fabpot commented Feb 10, 2015

@xabbuh Tests are fixed now.

@fabpot fabpot force-pushed the process-deprecations branch 2 times, most recently from 89d5de7 to 90ad34f Compare February 10, 2015 16:49
@fabpot fabpot force-pushed the process-deprecations branch from 90ad34f to a901ca2 Compare February 10, 2015 17:05
@fabpot fabpot merged commit a901ca2 into symfony:2.7 Feb 11, 2015
fabpot added a commit that referenced this pull request Feb 11, 2015
@fabpot
minor #13600 [Process] added a deprecation notice (fabpot)
9509fb7 
This PR was merged into the 2.7 branch.

Discussion
----------

[Process] added a deprecation notice

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #12703, #12725
| License       | MIT
| Doc PR        | n/a

Commits
-------

a901ca2 [Process] added a deprecation notice
@fabpot fabpot deleted the process-deprecations branch February 12, 2015 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabpot @xabbuh @nicolas-grekas @stof
0