[Process] Add deprecated logs on Process::setInput() and ProcessBuilder::setInput(). #12725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12703 |
| License | MIT |
| Doc PR |
| @@ -1092,6 +1092,7 @@ public function setStdin($stdin) | |||
| * Sets the input. | |||
| * | |||
| * This content will be passed to the underlying process standard input. | |||
| * Deprecation: As of Symfony 2.5, this method only accepts scalar values. | |||
There was a problem hiding this comment.
Can you use a @deprecated annotation instead?
There was a problem hiding this comment.
@fabpot Are you sure? Adding a @deprecated would mean that the entire method is deprecated, at least the IDE will understand it this way. If so I'll have to change it in ProcessBuilder::setInput() too.
…er::setInput() which does not accept non-scalar types.
1c6901b to
8c5b1de
Compare
| @@ -1101,6 +1102,13 @@ public function setStdin($stdin) | |||
| */ | |||
| public function setInput($input) | |||
| { | |||
| if (!is_scalar($input)) { | |||
| trigger_error( | |||
| 'Passing a non-scalar input is deprecated since version 2.5 and will be removed in 3.0.', | |||
There was a problem hiding this comment.
please format it this way:
There was a problem hiding this comment.
@timglabish I thought we have to break lines at 120 char. Are you sure?
|
The deprecation warning should actually be triggered in |
|
@tmartin Can you update this PR ? |
|
Closing in favor of #13600 |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [Process] added a deprecation notice | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12703, #12725 | License | MIT | Doc PR | n/a Commits ------- a901ca2 [Process] added a deprecation notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.