fixxed order of usage #13538
Closed
fixxed order of usage #13538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 2.7: Update filesystem readme.md to include exists method Add machine readable events Fixed minor typo [FrameworkBundle] Fix server start in case the PHP binary is not found Update UPGRADE-2.6.md [HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector fixed typo [Translations] Added missing Hebrew language trans-unit sources [DependencyInjection] inlined factory not referenced Fixed case for empty folder Fixed whitespace control for password form widget [Routing] correctly initialize condition as string
…(saro0h) This PR was merged into the 3.0-dev branch. Discussion ---------- [HttpKernel] Removed deprecated Kernel::init() method | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | maybe | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 37b49e1 [HttpKernel] Removed deprecated Kernel::init() method
* 2.7: Extract an AbstractEventDispatcherTest from EventDispatcherTest and also use it in ContainerAwareEventDispatcherTest [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners be smarter when guessing the document root Azerbaijani locale Fixed grammar error in docblock [HttpKernel] fix parse error in DumpDataCollector [TwigBundle/DebugBundle] move dump extension & cleanups Adjust upgrade file rendering [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions compare version using PHP_VERSION_ID [Form] Add doc for FormEvents *_timezone changes also affect the BirthdayType don't override internal PHP constants Drop support for model_timezone and view_timezone options in TimeType and DateType. [DomCrawler] Added support for link tags in the Link class [Session] Fix parameter names in WriteCheckSessionHandler Add consistency with request type checking [FrameworkBundle] Fix server run in case the router script does not exist
* 2.7: (36 commits) [Debug] fix error message on double exception [Validator] make DateTime objects represented as strings in the violation message. [RFC] [DebugBundle] [HttpKernel] Avoid using container as dependency for DumpListener Upgrade information for the Translation component regarding the new LoggingTranslator class. [WebProfilerBundle] Remove usage of app.request in search bar template Fix initialized() with aliased services fix data type in docblock Rename Symfony2 to Symfony bumped Symfony version to 2.6.0 updated VERSION for 2.6.0-BETA2 updated CHANGELOG for 2.6.0-BETA2 [Debug] fix ENT_SUBSTITUTE usage compare version using PHP_VERSION_ID backport #12489 remove an unneeded check Remove block submit_widget reformat code as suggested by @fabpot Fix typo Make `\Request::get` more performant. properly set request attributes in controller test ...
* 2.7: (65 commits) Configure firewall's kernel exception listener with configured entry point or a default entry point PSR-2 fixes [DependencyInjection] make paths relative to __DIR__ in the generated container [FrameworkBundle][Router Cmd] use debug namespace. [FrameworkBundle] Update deprecated service call Fix PHP Fatal error: Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37 Removed a dev annotation from a version constraint Fixed the syntax of a composer.json file Fixed the symfony/config version constraint Tweaked the password-compat version constraint Docblock fixes Append to PR #12737 referring Ticket #12704 Issue #12658 Add a deprecation note about Translator's setFallbackLocale... Issue #12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration... Hackday deprecated 12621 Added deprecation log for validate and validateValue on ExecutionContext... [Console] [Hackday] [2.7] Add a deprecation note about ProgressHelper [Hackday][2.7] Add a deprecation note about MetadataInterface's accept() method [Validator] Added a deprecation note about setPropertyAccessor #12698 [Locale] Adding a deprecation note about the Locale component ...
* 2.7: fixed wrong merge
* 2.7: [DependencyInjection] keep some of the reverted perf optim Revert "minor #10241 [DependencyInjection] made some perf improvements (fabpot)" Remove deprecated class
…nit tests (FlorianLB) This PR was squashed before being merged into the 3.0-dev branch (closes #12731). Discussion ---------- [Monolog Bridge] Remove deprecated log methods + add unit tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- Remove deprecated methods. I took the opportunity to add some missing unit tests. Commits ------- 9ecfc84 [Monolog Bridge] Remove deprecated log methods + add unit tests
This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][Process] Remove deprecated methods | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT Commits ------- e2334d9 [Process] Remove deprecated methods
* 2.7: (27 commits) Added information when an error occured during validation of an answer of a question Adding note about known BC issues Adding note about the PdoSessionHandler BC break [Console] fixes some typos and phpdoc. [HttpKernel] Add deprecation log for Kernel::isClassInActiveBundle() fix phpdoc's alignment [2.6] CS Fixes And Removed An Unused Import Minor phpcs fixes [ClassLoader] Fix undefined index in ClassCollectionLoader CS fixes Revert "minor #12821 Remove deprecated class (MasterB)" [2.3] More cs fixes Removed unused imports CS fixes bumped Symfony version to 2.6.2 updated VERSION for 2.6.1 updated CHANGELOG for 2.6.1 bumped Symfony version to 2.5.9 updated VERSION for 2.5.8 update CONTRIBUTORS for 2.5.8 ...
* 2.7: (26 commits) [Form] fixed a maxlength overring on a guessing [Debug] Show only unique class candidates [FrameworkBundle] make GetSetMethodNormalizer available by default [SecurityBundle] Firewall providers building - code cleaning [Filesystem] symlink use RealPath instead LinkTarget [DependencyInjection] Remove duplicate declaration in PhpDumper terminals are not interactive on Travis Revert "[DependencyInjection] backport perf optim" [WebProfiler] Tweaked ajax requests toolbar css reset [WebProfilerBundle] replaced pattern to path attribute in routes definitions. fix phpdoc's alignment Fixed deprecation version Fix missing addExpressionLanguageProvider (used by service container to add expression providers) Fixed the AuthenticationProviderInterface alignment Fixed the proxy-manager version constraint Fix missing space in label_attr fix DumpDataCollectorTest after CS changes avoid risky tests Fixed typo in SecurityContext PHPDoc [FrameworkBundle][Template name] avoid error message for the shortcut notation. ...
* 2.7: remove short array syntax fix session restart on PHP 5.3 Avoid missing method when using __invoke Show the inherited roles in the web profiler
* 2.7: Fix failing tests after merge fix ocramius/proxy-manager dependency version
* 2.7: [2.6] Test lowest versions of dependencies Test lowest versions of dependencies Fix placeholder date format Test components using their lowest possible deps
…InActiveBundle (hacfi) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][HttpKernel] Remove unused method Kernel::isClassInActiveBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes, if using isClassInActiveBundle (not used by Symfony itself) | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) Follow-up of #11869 Commits ------- 91dcca4 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle
* 2.7: (32 commits) [Config] adds missing « use » statement for InvalidTypeException type hint in documentation. [Config] fixes broken unit test on ArrayNode class. fixed CS [Security] Delete old session on auth strategy migrate skip if param "translator.logging" doesn't exist. [SecurityBundle] fixes SecurityDataCollector::getInheritedRoles() documentation. update required minimum TwigBridge version Very minor grammar fix in error message Added the function providers as container resources [Tests] Silenced all deprecations in tests for 2.3 BinaryFileResponse - add missing newline fixed CS add a limit and a test to FlattenExceptionTest. [DebugBundle] enable the DumpDataCollectorPass [FrameworkBundle] Use debug namespace. [FrameworkBundle] update debug commands references skip compiler pass if interface doesn't exist Unify the way to provide expression functions for the DI container CS: There should be no empty lines following phpdocs [Security] Added the triggering of the security.interactive_login event after set of token ... Conflicts: src/Symfony/Component/HttpKernel/Kernel.php
* 2.7: [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class.
…e namespace. (hhamon) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] [Bridge] [Swiftmailer] removed Swiftmailer bridge namespace. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- c70a616 [Bridge] [Swiftmailer] removes Swiftmailer bridge namespace.
This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] Removed all $that variables | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 7b33d1a Removed all $that variables
This PR was squashed before being merged into the 3.0-dev branch (closes #12994). Discussion ---------- Add LegacyPdoSessionHandler class | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12833 | License | MIT | Doc PR | N/A The changes made to the PdoSessionHandler in 2.6 introduced a backwards-compatability break for users upgrading from 2.5. This update introduces a LegacyPdoSessionHandler class that uses the old service's functionality. Users who cannot make schema updates or do not want to lose sessions can use LegacyPdoSessionHandler until 3.0. Commits ------- 20cb713 Add LegacyPdoSessionHandler class
* 2.7: [2.7] Added deprecated in debug command [FrameworkBundle] remove usage of deprecated Definition::setFactoryClass(), Definition::setFactoryService() and Definition::setFactoryMethod() methods. fixed some deprecated notices [Validator] fixed some legacy tests [Validator] fixed remaining notice [DX] Attempt to improve logging messages with parameters
…glas) This PR was merged into the 3.0-dev branch. Discussion ---------- [Serializer] Remove deprecated JSON error methods | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | n/a Remove deprecated methods of the Serializer component. Commits ------- 269aca6 [Serializer] Remove deprecated JSON error methods
* 2.7: removed deprecation notice for internal constant removed deprecated notices when using the security service [Validator] fixed deprecation notice for ElementMetadata Revert "minor #13434 fixed some deprecated notices (fabpot)" removed usage of the deprecated EsiListener class in core [security] Fetching current stored context when not explicitly specified [FrameworkBundle] Container parameters in Route#condition Deprecated setDefaultOptions() in favor of configureOptions() Conflicts: src/Symfony/Bridge/Doctrine/composer.json src/Symfony/Bridge/Propel1/composer.json src/Symfony/Bridge/Twig/AppVariable.php src/Symfony/Bundle/FrameworkBundle/composer.json src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/CsrfFormLoginBundle/Form/UserLoginFormType.php src/Symfony/Component/Form/Tests/ResolvedFormTypeTest.php
* 2.7: Minor plural/singular change print error message if server couldn't be started [HttpFoundation] [Request] fix baseUrl parsing to fix wrong path_info [Twig][Bridge][TranslationDefaultDomain] add support of named arguments. [Form] Improved exception message if the data class is not found Fixes ArgvInput's argument getter with empty tokens execute cheaper checks before more expensive ones [DependencyInjection] Fix missing ExpressionLanguageProviders on extension bild [FrameworkBundle] FormDataCollector should be loaded only if form config is enabled
This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] Travis Fix | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Previously we were not actually running the framework tests on php 5.6, but only the component tests. I assume we want the same setup we've got on the 2.7 branch. Commits ------- c217adb Travis fix
* 2.7: [TwigBridge] fixed AppVariable compat with older Symfony versions [Validator] re-added support for 2.4 API version in tests fixed typos fixed typo fixed typo fixed BC layer [SecurityBundle] decouple the logout PHP helper and Twig extension [Validator] added Japanese translation for unresolvable host (id: 79) [Serializer] Fix PHPDoc Conflicts: src/Symfony/Bridge/Twig/AppVariable.php
* 2.7: [TwigBundle] made AppVariable compatible with 3.0 fixed error message Conflicts: src/Symfony/Bridge/Twig/AppVariable.php
* 2.7: fixed tests [OptionsResolver] replaced some exception messages Added i18n support to ConfirmationQuestion [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result [Form] fixed form tests when using 2.7 deps [2.3] [HttpFoundation] [MimeTypeGuesser] [Routing] merge instead of replace class and method scheme/method annotations [TwigBridge] Fix bootstrap rendering when user explicitly use form_label Removed dead code and various cleaning Removed dead code and various cleaning Fixed HtmlDumper with long string Removed dead code and various cleaning [FrameworkBundle][xsd] added missing logging attribute. [Console] Make it clear that the second argument is not about command options. Added the '-' character for spaceless on tag start and end to be consistent for block, if, set and for nodes [Yaml] fixed parse shortcut Key after unindented collection. [Console] fixed #10531 Make the container considered non-fresh if the environment parameters are changed Conflicts: src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig src/Symfony/Component/HttpKernel/CHANGELOG.md src/Symfony/Component/Process/Process.php
* 2.7: Fix getComputedData added a Twig panel to the WebProfiler integrated the Twig profiler fixed condition fixed tests fixed PHP 5.3 compat Conflicts: src/Symfony/Bridge/Twig/composer.json src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExtensionPass.php src/Symfony/Bundle/WebProfilerBundle/composer.json
|
👎 |
|
i don't understand your vorting, can you please explain it to me? @hugohenrique thx |
|
Hi @OskarStark, |
|
@hugohenrique I don't see the reason of your downvote either, it's not about something broken, it's about a malformed looking message in the console. @OskarStark Can you fix the issue op in fabbot.io? If you make a PR, you see a big header telling you to view that page when making a contribution, you forgot that. That would have also made the point clear to @hugohenrique To me this change seems like a good one, but I don't know if this was done intentional. |
|
@iltar you are right, it loks malformed to mee, too. I updated the PR desc. If there were decisions i dont't know, please let me know. How can i re-trigger the fabpot.io check? Oskar |
|
@OskarStark, you should rebase and squash your commits and then force push them into your fork. |
|
@OskarStark Push something to your branch (OskarStark:patch-2). This will trigger the git hook that does the checks. If you follow what @kix suggested, it will happen too. |
|
thank you guys! |
fixxed order of usage fixxed order of usage Update application_astext1.txt fixxed order of usage fixxed order of usage
|
hmm, something went wrong... :( i forked symfony new and make a clean "patch-2" branch, shall i close and reopen the PR? sorry :( i think i rebased on master, instead of 2.7 branch ping @iltar |
|
Yes you need reopen a new PR. You don't have to fork the repository as GitHub already does this when doing a fast file editing. But for future its best to learn how to use Git the correct way as will save allot of hassle :) |
Closed
|
duplicate of #13545 |
fabpot
added a commit
that referenced
this pull request
Feb 5, 2015
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #13545). Discussion ---------- fixxed order of usage | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13537 | License | MIT | Doc PR | - ```[options] command [arguments]``` to ```command [options] [arguments]``` (i made some issues in this branch before #13538 ) Commits ------- d44ff2a fixxed order of usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line
2C95
comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[options] command [arguments]
to
command [options] [arguments]