[Monolog Bridge] Remove deprecated log methods + add unit tests #12731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add deprecation notices on 2.7, but do not remove methods on 3.0 because that will cause merge conflicts headaches for merges |
|
Thank you @FlorianLB. |
fabpot
added a commit
that referenced
this pull request
Dec 4, 2014
…nit tests (FlorianLB) This PR was squashed before being merged into the 3.0-dev branch (closes #12731). Discussion ---------- [Monolog Bridge] Remove deprecated log methods + add unit tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- Remove deprecated methods. I took the opportunity to add some missing unit tests. Commits ------- 9ecfc84 [Monolog Bridge] Remove deprecated log methods + add unit tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated methods. I took the opportunity to add some missing unit tests.