10000 [FrameworkBundle] fix routing descriptor for options by Tobion · Pull Request #13421 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] fix routing descriptor for options #13421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2015
Merged

[FrameworkBundle] fix routing descriptor for options #13421

merged 1 commit into from
Jan 15, 2015

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Jan 15, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The markdown descriptor for routes missed brackets, so that the options where actually ignored. Also fixed some other inconsistencies.

@Tobion
Copy link
Contributor Author
< 8000 div> Tobion commented Jan 15, 2015

@fabpot please merge 2.5 up to master then. So that I can rebase #13396.

@fabpot
Copy link
Member
fabpot commented Jan 15, 2015

Thank you @Tobion.

@fabpot fabpot merged commit b0c29a0 into symfony:2.5 Jan 15, 2015
fabpot added a commit that referenced this pull request Jan 15, 2015
@fabpot
bug #13421 [FrameworkBundle] fix routing descriptor for options (Tobion)
b53ceb1 
This PR was merged into the 2.5 branch.

Discussion
----------

[FrameworkBundle] fix routing descriptor for options

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The markdown descriptor for routes missed brackets, so that the `options` where actually ignored. Also fixed some other inconsistencies.

Commits
-------

b0c29a0 [FrameworkBundle] fix routing descriptor for options
@fabpot
Copy link
Member
fabpot commented Jan 15, 2015

merged in all branches now.

@Tobion Tobion deleted the fix-routing-descriptor branch January 15, 2015 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobion @fabpot
0