[Routing] remove deprecations for 3.0 #13396
Conversation
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | no, but unrelated |
| Fixed tickets | |
| License | MIT |
| Doc PR |
a457a04 to
b784ea5
Compare
|
@fabpot ready |
|
I forgot to remove pattern in |
b784ea5 to
4ca9ab3
Compare
|
Fixed |
|
Looks there is a problem somewhere as the tests do not pass. |
|
@fabpot I had to update the routing requirement in the frameworkbundle. The component tests should now succeed when the PR is merged. |
| @@ -23,7 +23,7 @@ | |||
| "symfony/http-foundation": "~2.7|~3.0", | |||
| "symfony/http-kernel": "~2.7|~3.0", | |||
| "symfony/filesystem": "~2.7|~3.0", | |||
| "symfony/routing": "~2.7|~3.0", | |||
| "symfony/routing": "~3.0", | |||
There was a problem hiding this comment.
That would be the first where this would be needed.
There was a problem hiding this comment.
It's only required for tests not the actual functionality (because _scheme/_method would not hurt). Is it possible to have the same dependecy with different versions for require and require-dev?
I.e. ~2.7|~3.0 in require but ~3.0 in require-dev?
There was a problem hiding this comment.
No it's not unfortunately. You should adjust the tests to make them less strict. With assertStringMatchesFormat it should be possible.
There was a problem hiding this comment.
Or we just leave it this way. Sooner or later its gonna happen anyway.
There was a problem hiding this comment.
why is it required for tests of the FrameworkBundle ? Which test is actually breaking when running it on Routing 2.7 ?
There was a problem hiding this comment.
the one describing routes in the console in xml, yaml etc format
|
@symfony/deciders ping |
|
👍 |
pattern was previously also required, see symfony@5082994#diff-4
This PR was merged into the 3.0-dev branch. Discussion ---------- [Routing] remove deprecations for 3.0 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | no, but unrelated | Fixed tickets | | License | MIT | Doc PR | Commits ------- f939fea [Routing] make path required again in the xsd 82d54fa [FramworkBundle] our tests now expect symfony 3.0 behavior for routing 4ca9ab3 [FrameworkBundle] remove deprecated routing features 86278cd [Routing] remove deprecated features from routing
|
I'm not satisfied with the Composer dep as everywhere else we were able to avoid doing that. |
|
Well otherwise we would need to add the |
|
And just fixing the test would still confuse users. Because they would see a |