[FrameworkBundle] Enable 'debug:translation' command to inspect directories#13340
[FrameworkBundle] Enable 'debug:translation' command to inspect directories#13340xelaris wants to merge 1 commit intosymfony:2.5from
Conversation
|
It adds a new flag, so this is definitely a new feature and it will be merged in 2.7 instead. |
There was a problem hiding this comment.
Do we really need a new option? What about looking for a path if the bundle does not exist instead?
This enables not only to inspect Bundles, but also directories, like the app/ directory for instance.
f2c82e5 to
37d53ff
Compare
|
Thanks for the feedback @fabpot. I changed it according to your suggestion. |
|
Looks good to me now 👍 |
|
|
|
Nice hint @stof. I had a look at the |
|
@xelaris Opening a new one for 2.7 and make both commands behave the same looks like the way to go. I would not create an abstract class though. Thanks. |
|
closed in favor of #13443 |
…tion debugging in directories (xelaris) This PR was merged into the 2.7 branch. Discussion ---------- [Translation][Command][FrameworkBundle] Enable translation debugging in directories | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12273 | License | MIT | Doc PR | This PR follows up #13340 and enables not only to inspect Bundles, but also directories, like the `app/` directory. Additionally it harmonizes the TranslationDebugCommand and TranslationUpdateCommand to expect an optional bundle name or a directory and fall back to kernel root dir if none of them is given. Commits ------- 2662244 [FrameworkBundle] Enable translation debugging in directories
This enables not only to inspect Bundles, but also directories, like the
app/directory for instance.I'm not sure about the branch, strictly speaking it's a new feature, but in some way a bug fix too.