8000 [Translation] translation:debug for views in app/ folder · Issue #12273 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[Translation] translation:debug for views in app/ folder #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sebastianblum opened this issue Oct 21, 2014 · 3 comments
Closed

[Translation] translation:debug for views in app/ folder #12273

sebastianblum opened this issue Oct 21, 2014 · 3 comments
Labels
Translation

Comments

@sebastianblum
Copy link

In the symfony best-practices, it is recommended, that the templates are stored in app/views/ (page 26).

But at the moment, it is not possible to debug the translation files

app/console translation:debug de AppBundle

doesn't find templates in the app/views/ folder.
@javiereguiluz
Copy link
Member

@sebastianblum thanks for reporting this error!

It's true that the current translation:debug command is incompatible with the Symfony Best Practices because it requires to provide the name of some bundle.

I wonder if there is an easy way to update the command to allow scanning templates in any given directory and without breaking BC (or without breaking BC too much).

@sebastianbergmann
Copy link
Contributor

s/bergmann/blum/ ;-)

@stof
Copy link
Member
stof commented Oct 21, 2014

IMO, translation:debug would be better based on the domain rather than the bundle. The translator does not distinguish translations per bundle but per domain

@javiereguiluz javiereguiluz mentioned this issue Oct 21, 2014
Closed
14 tasks
@xelaris xelaris mentioned this issue Jan 9, 2015
Closed
@xelaris xelaris mentioned this issue Jan 18, 2015
Merged
aitboudad added a commit that referenced this issue Apr 6, 2015
@aitboudad
feature #13443 [Translation][Command][FrameworkBundle] Enable transla…
cc13ae4 
…tion debugging in directories (xelaris)

This PR was merged into the 2.7 branch.

Discussion
----------

[Translation][Command][FrameworkBundle] Enable translation debugging in directories

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12273
| License       | MIT
| Doc PR        |

This PR follows up #13340 and enables not only to inspect Bundles, but also directories, like the `app/` directory.

Additionally it harmonizes the TranslationDebugCommand and TranslationUpdateCommand to expect an optional bundle name or a directory and fall back to kernel root dir if none of them is given.

Commits
-------

2662244 [FrameworkBundle] Enable translation debugging in directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sebastianbergmann @fabpot @javiereguiluz @stof @sebastianblum @aitboudad
0