8000 [2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class. by hhamon · Pull Request #13049 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class. #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2014
Merged

[2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class. #13049

merged 1 commit into from
Dec 21, 2014

Conversation

hhamon
Copy link
Contributor
@hhamon hhamon commented Dec 20, 2014
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

@hhamon hhamon changed the title [SecurityBundle] adds unit tests suite for SecurityDataCollector class. [2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class. Dec 20, 2014
@hhamon hhamon force-pushed the securitydatacollector-unit-tests branch from 09207dd to 232982f Compare December 20, 2014 12:01
fabpot
fabpot reviewed Dec 20, 2014
View reviewed changes
src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php

protected function setUp()
{
$this->request = $this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to a getRequest() method instead? The same goes for the response.

@hhamon hhamon force-pushed the securitydatacollector-unit-tests branch from 232982f to 85f72f4 Compare December 20, 2014 21:33
@hhamon
Copy link
Contributor Author
hhamon commented Dec 20, 2014

@Tobion & @fabpot changes have been applied.

@Tobion
Copy link
Contributor
Tobion commented Dec 20, 2014

👍

@fabpot
Copy link
Member
fabpot commented Dec 21, 2014

Thank you @hhamon.

@fabpot fabpot merged commit 85f72f4 into symfony:2.3 Dec 21, 2014
fabpot added a commit that referenced this pull request Dec 21, 2014
@fabpot
minor #13049 [2.3] [SecurityBundle] adds unit tests suite for Securit…
c9acca7 
…yDataCollector class. (hhamon)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

85f72f4 [SecurityBundle] adds unit tests suite for SecurityDataCollector class.
@hhamon hhamon deleted the securitydatacollector-unit-tests branch December 21, 2014 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hhamon @Tobion @fabpot
0