8000 [2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class. by hhamon · Pull Request #13049 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class. #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2014
Merged

[2.3] [SecurityBundle] adds unit tests suite for SecurityDataCollector class. #13049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Symfony/Bundle/SecurityBundle/DataCollector/SecurityDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace Symfony\Bundle\SecurityBundle\DataCollector;

use Symfony\Component\Security\Core\Role\RoleInterface;
use Symfony\Component\Security\Core\SecurityContextInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
Expand All @@ -25,6 +26,11 @@ class SecurityDataCollector extends DataCollector
{
private $context;

/**
* Constructor.
*
* @param SecurityContextInterface|null $context
*/
public function __construct(SecurityContextInterface $context = null)
{
$this->context = $context;
Expand Down Expand Up @@ -57,7 +63,7 @@ public function collect(Request $request, Response $response, \Exception $except
'authenticated' => $token->isAuthenticated(),
'token_class' => get_class($token),
'user' => $token->getUsername(),
'roles' => array_map(function ($role) { return $role->getRole();}, $token->getRoles()),
'roles' => array_map(function (RoleInterface $role) { return $role->getRole(); }, $token->getRoles()),
);
}
}
Expand Down
87 changes: 87 additions & 0 deletions src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
<?php

namespace Symfony\Bundle\SecurityBundle\Tests\DataCollector;

use Symfony\Bundle\SecurityBundle\DataCollector\SecurityDataCollector;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
use Symfony\Component\Security\Core\Role\Role;

class SecurityDataCollectorTest extends \PHPUnit_Framework_TestCase
{
public function testCollectWhenSecurityIsDisabled()
{
$collector = new SecurityDataCollector();
$collector->collect($this->getRequest(), $this->getResponse());

$this->assertSame('security', $collector->getName());
$this->assertFalse($collector->isEnabled());
$this->assertFalse($collector->isAuthenticated());
$this->assertNull($collector->getTokenClass());
$this->assertCount(0, $collector->getRoles());
$this->assertEmpty($collector->getUser());
}

public function testCollectWhenAuthenticationTokenIsNull()
{
$securityContext = $this->getMock('Symfony\Component\Security\Core\SecurityContextInterface');
$securityContext->expects($this->once())->method('getToken')->willReturn(null);

$collector = new SecurityDataCollector($securityContext);
$collector->collect($this->getRequest(), $this->getResponse());

$this->assertTrue($collector->isEnabled());
$this->assertFalse($collector->isAuthenticated());
$this->assertNull($collector->getTokenClass());
$this->assertCount(0, $collector->getRoles());
$this->assertEmpty($collector->getUser());
}

/** @dataProvider provideRoles */
public function testCollectAuthenticationTokenAndRoles(array $roles, array $normalizedRoles)
{
$securityContext = $this->getMock('Symfony\Component\Security\Core\SecurityContextInterface');
$securityContext
->expects($this->once())
->method('getToken')
->willReturn(new UsernamePasswordToken('hhamon', 'P4$$w0rD', 'provider', $roles));

$collector = new SecurityDataCollector($securityContext);
$collector->collect($this->getRequest(), $this->getResponse());

$this->assertTrue($collector->isEnabled());
$this->assertTrue($collector->isAuthenticated());
$this->assertSame('Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken', $collector->getTokenClass());
$this->assertSame($normalizedRoles, $collector->getRoles());
$this->assertSame('hhamon', $collector->getUser());
}

public function provideRoles()
{
return array(
array(
array('ROLE_USER'),
array('ROLE_USER'),
),
array(
array(new Role('ROLE_USER')),
array('ROLE_USER'),
),
);
}

private function getRequest()
{
return $this
->getMockBuilder('Symfony\Component\HttpFoundation\Request')
->disableOriginalConstructor()
->getMock();
}

private function getResponse()
{
return $this
->getMockBuilder('Symfony\Component\HttpFoundation\Response')
->disableOriginalConstructor()
->getMock();
}
}
0