Deprecations #12968
Merged
Deprecations #12968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (__CLASS__ !== $defClass) { | ||
| trigger_error(sprintf('Calling %s::init() was deprecated in Symfony 2.3 and will be removed in 3.0. Move your logic to the constructor instead.', $defClass), E_USER_DEPRECATED); | ||
| $this->init(); | ||
| } |
There was a problem hiding this comment.
I'm not convinced this is worth the overhead.
There was a problem hiding this comment.
I should benchmark with https://blackfire.io/ :)
As this is executed only once, I'm not sure this is relevant.
Is there any better way?
4e2e7d1 to
badf8fc
Compare
This was referenced Dec 15, 2014
| @@ -85,7 +87,7 @@ | |||
| * | |||
| * @Event | |||
| */ | |||
| const BIND = 'form.bind'; | |||
| const BIND = Deprecated::BIND; | |||
There was a problem hiding this comment.
this will autoload the referenced class or not? and thus trigger the deprecation even when the constant is no used at all?!
There was a problem hiding this comment.
this is the trick: PHP lazy loads values of constants, so this won't be triggered unless used.
There was a problem hiding this comment.
Looks like so: http://3v4l.org/vETtp
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 20, 2014
…cmorales) This PR was merged into the 2.7 branch. Discussion ---------- Deprecations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12625, #12605, #12628, #12622, #12642, #12609, #12651, #12604, #12607, #12667, #12648 | License | MIT | Doc PR | - Cherry-picking some pending PRs to make them move forward Commits ------- badf8fc [Form] Log deprecation of constants, fixes #12607 #12667 1d58df4 Fix deprecation notice on VirtualFormAwareIterator e2a19ee Add a deprecation note about VirtualFormAwareIterator ab4d9b8 Add a deprecation note about CsrfProviderInterface cb70632 [HttpKernel] fix deprecation notice for Kernel::init() b5a315d [HttpKernel] Added deprecated error to init() 70012c1 [Hackday] [2.7] Add a deprecation note about TypeTestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking some pending PRs to make them move forward