8000 [Hackday] [2.7] Add a deprecation note about ROUND_* constants · Issue #12607 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Hackday] [2.7] Add a deprecation note about ROUND_* constants #12607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Nov 29, 2014 · 3 comments
Closed

[Hackday] [2.7] Add a deprecation note about ROUND_* constants #12607

javiereguiluz opened this issue Nov 29, 2014 · 3 comments

Comments

@javiereguiluz
Copy link
Member

NOTE: This issue is part of the "SymfonyCon 2014 Madrid Hackday" effort to add logs for every 2.7 deprecated feature. This is needed before removing those features in 3.0 version. Please, add you name in a comment of this issue if you are going to work on this.

The constants ROUND_HALFEVEN, ROUND_HALFUP and ROUND_HALFDOWN in class NumberToLocalizedStringTransformer were renamed to ROUND_HALF_EVEN, ROUND_HALF_UP and ROUND_HALF_DOWN.
@toin0u
Copy link
Contributor
toin0u commented Nov 29, 2014

Is this not already done ? https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php#L75-L94

@aferrandini
Copy link
Contributor

If you need it, this Gist explains how to generate the deprecation note:

https://gist.github.com/javiereguiluz/a5514ec6cde2a63be441

toin0u added a commit to toin0u/symfony that referenced this issue Nov 29, 2014
@toin0u
[Form] add deprecation log (symfony#12607)
71eeb20
@toin0u toin0u mentioned this issue Nov 29, 2014
Closed
@toin0u
Copy link
Contributor
toin0u commented Nov 29, 2014

@aferrandini thanks for you help :)

toin0u added a commit to toin0u/symfony that referenced this issue Nov 29, 2014
@toin0u
[Form] add deprecation log (symfony#12607)
b612ddb
toin0u added a commit to toin0u/symfony that referenced this issue Dec 1, 2014
@toin0u
[Form] add deprecation log (symfony#12607)
4aeabce
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this issue Dec 15, 2014
@nicolas-grekas
[Form] Log deprecation of constants, fixes symfony#12607 symfony#12667
4e2e7d1
@nicolas-grekas nicolas-grekas mentioned this issue Dec 15, 2014
Merged
fabpot added a commit that referenced this issue Dec 20, 2014
@fabpot
minor #12968 Deprecations (jzawadzki, dkvk, nicolas-grekas, picur, mr…
13fae15 
…cmorales)

This PR was merged into the 2.7 branch.

Discussion
----------

Deprecations

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12625, #12605, #12628, #12622, #12642, #12609, #12651, #12604,  #12607, #12667, #12648
| License       | MIT
| Doc PR        | -

Cherry-picking some pending PRs to make them move forward

Commits
-------

badf8fc [Form] Log deprecation of constants, fixes #12607 #12667
1d58df4 Fix deprecation notice on VirtualFormAwareIterator
e2a19ee Add a deprecation note about VirtualFormAwareIterator
ab4d9b8 Add a deprecation note about CsrfProviderInterface
cb70632 [HttpKernel] fix deprecation notice for Kernel::init()
b5a315d [HttpKernel] Added deprecated error to init()
70012c1 [Hackday] [2.7] Add a deprecation note about TypeTestCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @aferrandini @toin0u
0