[DependencyInjection] Removed unreachable code #12072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unkind Did you find this because your ide reported this? The code might be wrong but removing this entirely is not a good idea imho! |
|
I cannot find any case when interpreter hits this code, feel free to correct me if you think it breaks BC somehow. |
|
After debugging this I think @unkind is right. 3 lines before |
|
this indeed looks like dead code. 👍 |
|
Good catch, thanks @unkind. |
fabpot
added a commit
that referenced
this pull request
Sep 29, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [DependencyInjection] Removed unreachable code | Q | A | ------------- | --- | Bug fix? | not really | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a According to undefined $e, this is an unreachable code. As I can see, circular references are handled by parent method. Commits ------- ecedea2 [DependencyInjection] Removed unreachable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to undefined $e, this is an unreachable code. As I can see, circular references are handled by parent method.