minor #12072 [DependencyInjection] Removed unreachable code (unkind)

fabpot · fabpot · commit f3ef9d200993 · 2014-09-29T13:38:42.000+02:00
This PR was merged into the 2.6-dev branch. Discussion ---------- [DependencyInjection] Removed unreachable code | Q | A | ------------- | --- | Bug fix? | not really | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a According to undefined $e, this is an unreachable code. As I can see, circular references are handled by parent method. Commits ------- ecedea2 [DependencyInjection] Removed unreachable code
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -470,10 +470,6 @@ public function get($id, $invalidBehavior = ContainerInterface::EXCEPTION_ON_INV
             return $service;
         }
 
-        if (isset($this->loading[$id])) {
-            throw new LogicException(sprintf('The service "%s" has a circular reference to itself.', $id), 0, $e);
-        }
-
         if (!$this->hasDefinition($id) && isset($this->aliasDefinitions[$id])) {
             return $this->get($this->aliasDefinitions[$id]);
         }

Original file line number	Diff line number	Diff line change
`@@ -470,10 +470,6 @@ public function get($id, $invalidBehavior = ContainerInterface::EXCEPTION_ON_INV`
`470`	`470`	`return $service;`
`471`	`471`	`}`
`472`	`472`
`473`		`- if (isset($this->loading[$id])) {`
`474`		`- throw new LogicException(sprintf('The service "%s" has a circular reference to itself.', $id), 0, $e);`
`475`		`- }`
`476`		`-`
`477`	`473`	`if (!$this->hasDefinition($id) && isset($this->aliasDefinitions[$id])) {`
`478`	`474`	`return $this->get($this->aliasDefinitions[$id]);`
`479`	`475`	`}`