10000 [Finder] [Iterator] Make the tests less fragile by AlphaStream · Pull Request #12028 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Finder] [Iterator] Make the tests less fragile #12028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Finder] [Iterator] Make the tests less fragile #12028

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
236623f
Make Finder's Iterator tests less fragile
AlphaStream Sep 24, 2014
9392e05
Make the proposed changes.
AlphaStream Sep 25, 2014
041ad8e
Apply the coding standard-fixing patch.
AlphaStream Sep 25, 2014
979fe0e
Removed a redundant check.
AlphaStream Sep 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed a redundant check.
  • Loading branch information
@AlphaStream
AlphaStream committed Sep 25, 2014
commit 979fe0e3d052faf03944c78e84b71fd73cdd0f4d
5 changes: 2 additions & 3 deletions src/Symfony/Component/Finder/Tests/Iterator/SortableIteratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,9 @@ public function testAccept($mode, $expected)

$iterator = new SortableIterator($inner, $mode);

if (!is_callable($mode) &&
($mode === SortableIterator::SORT_BY_ACCESSED_TIME
if ($mode === SortableIterator::SORT_BY_ACCESSED_TIME
|| $mode === SortableIterator::SORT_BY_CHANGED_TIME
|| $mode === SortableIterator::SORT_BY_MODIFIED_TIME)) {
|| $mode === SortableIterator::SORT_BY_MODIFIED_TIME) {
$this->assertOrderedIteratorForGroups($expected, $iterator);
} else {
$this->assertOrderedIterator($expected, $iterator);
Expand Down
0