[Finder] [Iterator] Make the tests less fragile #12028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Finder] Modified the Iterator tests so that they assert only on what's actually being tested. In particular, the tests were checking the order of the files that were created at the same time after sorting them by date. This change is a part of the effort to make Symfony successfully pass tests on HHVM
| } | ||
|
|
||
| public function getAcceptData() | ||
| { | ||
|
|
|
Thank you @AlphaStream. |
fabpot
added a commit
that referenced
this pull request
Sep 26, 2014
…ream) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12028). Discussion ---------- [Finder] [Iterator] Make the tests less fragile Modified the Iterator tests so that they assert only on what's actually being tested. In particular, the tests were checking the order of the files [that were created virtually simultaneously] after sorting them by date. This change is a part of the effort to make Symfony successfully pass tests on HHVM | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | Fixed tickets | [none] | License | MIT | Doc PR | [none] Commits ------- 10f9135 [Finder] [Iterator] Make the tests less fragile
|
Thanks for merging it @fabpot . Is there a reason you merged in into 2.3, not master? |
|
Because we always merge bug fixes in the oldest and still maintained branch. Then, on a regular basis, oldest branches are merged into newer ones. |
|
Got it! Is there any rough estimate when the fix may show up in 2.4? Such as, within a day/week/month? |
|
couple of days |
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the Iterator tests so that they assert only on what's actually being tested. In particular, the tests were checking the order of the files [that were created virtually simultaneously] after sorting them by date. This change is a part of the effort to make Symfony successfully pass tests on HHVM