[Finder][Urgent] Remove asterisk and question mark from folder name in test to prevent windows file system issues. #11989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilesystem issues. A previous commit introduced a folder with a question mark and an asterisk which are invalid NTFS folder name characters and prevented checkout on those systems.
|
@phazei May you close the other pull requests? I kind of find it hard now to get the best one - thinks this one here, is. |
This was referenced Sep 23, 2014
|
Thank you @phazei. |
fabpot
added a commit
that referenced
this pull request
Sep 23, 2014
…lder name in test to prevent windows file system issues. (Adam) This PR was merged into the 2.3 branch. Discussion ---------- [Finder][Urgent] Remove asterisk and question mark from folder name in test to prevent windows file system issues. Bugfix: Yes Fixed tickets: #11984 , #11985 Related tickets: #11970 Commit #11970 prevented Symphony from being checked out via windows due to invalid characters in a folder name within the tests. The issue was reported in #11984 and was attempted to be fixed in #11985 but wasn't due to still including the question mark. Please accept this ASAP as it entirely breaks any composer that relies on it. Commits ------- 5fbb278 Avoid question mark and asterisk in folder names to prevent windows filesystem issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Yes
Fixed tickets: #11984 , #11985
Related tickets: #11970
Commit #11970 prevented Symphony from being checked out via windows due to invalid characters in a folder name within the tests.
The issue was reported in #11984 and was attempted to be fixed in #11985 but wasn't due to still including the question mark.
Please accept this ASAP as it entirely breaks any composer that relies on it.