[FrameworkBundle] Remove invalid markup #11897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #11896 |
| License | MIT |
| Doc PR | n/a |
|
👍 |
1 similar comment
|
👍 |
|
should be merged in 2.3. |
|
actually, this fixes only half of the issue. I detected the second part of the mistake (I explained it in the issue). |
|
@stof OK, done. I also added the missing check for |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @flack. |
fabpot
added a commit
that referenced
this pull request
Sep 10, 2014
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #11897). Discussion ---------- [FrameworkBundle] Remove invalid markup | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11896 | License | MIT | Doc PR | n/a Commits ------- 1fe8e31 [FrameworkBundle] Remove invalid markup
|
@fabpot just another quick question: I saw that you merged the changes into the 2.3 branch, but not into master. Will this be done by some other process later on? Because all branches I've checked (2.1, 2.2, 2.3, 2.4, 2.5, master) are affected |
|
@flack 2.3 will be merged into 2.4 which will be merged into 2.5 and so on. Though this isn't done after each PR is merged but from time to time. So it may take some time to see your commit in master, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.