8000 Invalid HTML in form_widget_compound.html.php · Issue #11896 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Invalid HTML in form_widget_compound.html.php #11896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flack opened this issue Sep 9, 2014 · 2 comments
Closed

Invalid HTML in form_widget_compound.html.php #11896

flack opened this issue Sep 9, 2014 · 2 comments
Labels
Bug Form

Comments

@flack
Copy link
Contributor
flack commented Sep 9, 2014

Not sure if this was reported already, but I couldn't find anything, so here goes:

in

https://github.com/symfony/symfony/blob/2.5/src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/form_widget_compound.html.php#L3

there is a <tr><td> structure included inside a normal <div> element, which is ofc completely invalid HTML. I did a quick search with git blame and it seems to have been introduced in this commit:

df5bb4a#diff-fc04881cc6d3293b085be7e53f5c0bf9R3

Copy n Paste error?
@Tobion
Copy link
Contributor
Tobion commented Sep 9, 2014

Yes it's a bug. This structure should only be used when using the table form rendering. We would appreciate a PR to fix it.

@flack flack mentioned this issue Sep 9, 2014
Closed
@stof
Copy link
Member
stof commented Sep 10, 2014

There is the opposite error in the FormTable theme: the tr/td is missing (the tr/td has been added in the wrong template)

fabpot added a commit that referenced this issue Sep 10, 2014
@fabpot
bug #11897 [FrameworkBundle] Remove invalid markup (flack)
aa16baf 
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #11897).

Discussion
----------

[FrameworkBundle] Remove invalid markup

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11896
| License       | MIT
| Doc PR        | n/a

Commits
-------

1fe8e31 [FrameworkBundle] Remove invalid markup
@fabpot fabpot closed this as completed Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @flack @stof @Tobion
0